Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK Lowcode: allow parametrizing initial page when using PageIncrement #19712

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

davydov-d
Copy link
Collaborator

What

PageIncrement starts counting pages from 0 which is not always a good choice

How

Allow configuring the number of the start page

Use case: pagination starts from 1 in Zenloop, Delighted(work in progress)

@davydov-d davydov-d requested a review from a team as a code owner November 22, 2022 14:29
@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Nov 22, 2022
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! one note about the minor version increment instead of patch

airbyte-cdk/python/setup.py Outdated Show resolved Hide resolved
@grubberr
Copy link
Contributor

@davydov-d
do we wait Monday 28.11 here ?

@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 28, 2022

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3566528245
https://github.com/airbytehq/airbyte/actions/runs/3566528245

@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 28, 2022

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3566628720
https://github.com/airbytehq/airbyte/actions/runs/3566628720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK Lowcode: allow parametrizing initial page when using PageIncrement
5 participants