No longer forces custom source/destination definition always #19627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
ambirdsall
approved these changes
Nov 19, 2022
There was a problem hiding this comment.
This fix makes sense in light of the bug as reported/diagnosed (create/update calls failed for all non-custom connectors since they used the custom connector create/update calls but lacked the corresponding grants). I did confirm that this correctly reverts all usages of these methods, but did not fully test locally.
This was referenced Nov 20, 2022
davinchia
pushed a commit
that referenced
this pull request
Nov 23, 2022
Closes #19637 PR that introduced this bug was a precision revert of another issue: #19627 This PR removes the createSourceDefinition() and createDestinationDefinition() methods in favor of the new createCustomSourceDefinition() and createCustomDestinationDefinition() methods. createSourceDefinition() and createDestinationDefinition() are to be deprecated. This PR does not address updating custom connectors. There is a backend issue for fixing this behavior here: #19669
SofiiaZaitseva
pushed a commit
that referenced
this pull request
Nov 24, 2022
Closes #19637 PR that introduced this bug was a precision revert of another issue: #19627 This PR removes the createSourceDefinition() and createDestinationDefinition() methods in favor of the new createCustomSourceDefinition() and createCustomDestinationDefinition() methods. createSourceDefinition() and createDestinationDefinition() are to be deprecated. This PR does not address updating custom connectors. There is a backend issue for fixing this behavior here: #19669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduced a bug that made all source and destination definitions create or update a custom.
Rather than a full revert, this PR simply returns the old functionality.