Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer forces custom source/destination definition always #19627

Merged
merged 1 commit into from
Nov 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { AirbyteRequestService } from "core/request/AirbyteRequestService";

import {
createCustomDestinationDefinition,
CustomDestinationDefinitionCreate,
CustomDestinationDefinitionUpdate,
createDestinationDefinition,
DestinationDefinitionCreate,
DestinationDefinitionIdWithWorkspaceId,
DestinationDefinitionUpdate,
getDestinationDefinitionForWorkspace,
listDestinationDefinitionsForWorkspace,
listLatestDestinationDefinitions,
updateCustomDestinationDefinition,
updateDestinationDefinition,
} from "../../request/AirbyteClient";

export class DestinationDefinitionService extends AirbyteRequestService {
Expand All @@ -24,11 +24,11 @@ export class DestinationDefinitionService extends AirbyteRequestService {
return listLatestDestinationDefinitions(this.requestOptions);
}

public update(body: CustomDestinationDefinitionUpdate) {
return updateCustomDestinationDefinition(body, this.requestOptions);
public update(body: DestinationDefinitionUpdate) {
return updateDestinationDefinition(body, this.requestOptions);
}

public create(body: CustomDestinationDefinitionCreate) {
return createCustomDestinationDefinition(body, this.requestOptions);
public create(body: DestinationDefinitionCreate) {
return createDestinationDefinition(body, this.requestOptions);
}
}
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { AirbyteRequestService } from "core/request/AirbyteRequestService";

import {
createCustomSourceDefinition,
CustomSourceDefinitionCreate,
getSourceDefinitionForWorkspace,
listLatestSourceDefinitions,
listSourceDefinitionsForWorkspace,
CustomSourceDefinitionUpdate,
updateCustomSourceDefinition,
SourceDefinitionIdWithWorkspaceId,
updateSourceDefinition,
SourceDefinitionUpdate,
createSourceDefinition,
SourceDefinitionCreate,
} from "../../request/AirbyteClient";

export class SourceDefinitionService extends AirbyteRequestService {
Expand All @@ -24,11 +24,11 @@ export class SourceDefinitionService extends AirbyteRequestService {
return listLatestSourceDefinitions(this.requestOptions);
}

public update(body: CustomSourceDefinitionUpdate) {
return updateCustomSourceDefinition(body, this.requestOptions);
public update(body: SourceDefinitionUpdate) {
return updateSourceDefinition(body, this.requestOptions);
}

public create(body: CustomSourceDefinitionCreate) {
return createCustomSourceDefinition(body, this.requestOptions);
public create(body: SourceDefinitionCreate) {
return createSourceDefinition(body, this.requestOptions);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,9 @@ const useDestinationDefinition = <T extends string | undefined>(
const useCreateDestinationDefinition = () => {
const service = useGetDestinationDefinitionService();
const queryClient = useQueryClient();
const workspaceId = useCurrentWorkspaceId();

return useMutation<DestinationDefinitionRead, Error, DestinationDefinitionCreate>(
(destinationDefinition) => service.create({ workspaceId, destinationDefinition }),
(destinationDefinition) => service.create(destinationDefinition),
{
onSuccess: (data) => {
queryClient.setQueryData(
Expand All @@ -96,7 +95,6 @@ const useCreateDestinationDefinition = () => {
const useUpdateDestinationDefinition = () => {
const service = useGetDestinationDefinitionService();
const queryClient = useQueryClient();
const workspaceId = useCurrentWorkspaceId();

return useMutation<
DestinationDefinitionRead,
Expand All @@ -105,7 +103,7 @@ const useUpdateDestinationDefinition = () => {
destinationDefinitionId: string;
dockerImageTag: string;
}
>((destinationDefinition) => service.update({ workspaceId, destinationDefinition }), {
>((destinationDefinition) => service.update(destinationDefinition), {
onSuccess: (data) => {
queryClient.setQueryData(destinationDefinitionKeys.detail(data.destinationDefinitionId), data);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,9 @@ const useSourceDefinition = <T extends string | undefined>(
const useCreateSourceDefinition = () => {
const service = useGetSourceDefinitionService();
const queryClient = useQueryClient();
const workspaceId = useCurrentWorkspaceId();

return useMutation<SourceDefinitionRead, Error, SourceDefinitionCreate>(
(sourceDefinition) => service.create({ workspaceId, sourceDefinition }),
(sourceDefinition) => service.create(sourceDefinition),
{
onSuccess: (data) => {
queryClient.setQueryData(
Expand All @@ -94,7 +93,6 @@ const useCreateSourceDefinition = () => {
const useUpdateSourceDefinition = () => {
const service = useGetSourceDefinitionService();
const queryClient = useQueryClient();
const workspaceId = useCurrentWorkspaceId();

return useMutation<
SourceDefinitionRead,
Expand All @@ -103,7 +101,7 @@ const useUpdateSourceDefinition = () => {
sourceDefinitionId: string;
dockerImageTag: string;
}
>((sourceDefinition) => service.update({ workspaceId, sourceDefinition }), {
>((sourceDefinition) => service.update(sourceDefinition), {
onSuccess: (data) => {
queryClient.setQueryData(sourceDefinitionKeys.detail(data.sourceDefinitionId), data);

Expand Down