Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "RecordSchemaValidator can resolve $ref schemas" #20113

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Revert "RecordSchemaValidator can resolve $ref schemas" #20113

merged 1 commit into from
Dec 6, 2022

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Dec 6, 2022 •
edited by ryankfu
Loading

Reverts #19625

Context: Slack thread

Execution failed for task ':airbyte-workers:buildDockerImage'.
Could not build image: COPY failed: file not found in build context or excluded by .dockerignore: stat
WellKnownTypes.json: file does not exist

@gosusnp gosusnp requested a review from a team as a code owner December 6, 2022 01:41
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Dec 6, 2022
@gosusnp gosusnp temporarily deployed to more-secrets December 6, 2022 01:43 Inactive
@gosusnp gosusnp temporarily deployed to more-secrets December 6, 2022 01:43 Inactive
@gosusnp gosusnp temporarily deployed to more-secrets December 6, 2022 16:49 Inactive
@gosusnp gosusnp temporarily deployed to more-secrets December 6, 2022 16:49 Inactive
@gosusnp gosusnp merged commit 86f61a5 into master Dec 6, 2022
@gosusnp gosusnp deleted the revert-19625-edgao/wellknowntypes_in_worker branch December 6, 2022 19:19
This was referenced Dec 6, 2022
Closed
Merged
edgao added a commit that referenced this pull request Dec 13, 2022
@edgao
Revert "Revert "RecordSchemaValidator can resolve $ref schemas (#19625)…
eb859f8 
…" (#20113)"

This reverts commit 86f61a5.
edgao added a commit that referenced this pull request Dec 15, 2022
@edgao
Enable record schema validation using v1 type system; CI uses MSG to …
2392acb 
…start EC2 runners (#20439)

* Revert "Revert "RecordSchemaValidator can resolve $ref schemas (#19625)" (#20113)"

This reverts commit 86f61a5.

* just hardcode build?

* sshable instance

* pass arg for release oss only

* also skip octavia + create PR

* update ec2 runner

* revert CI test changes

* whoops

* whoopswhoops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@ryankfu ryankfu ryankfu approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gosusnp @girarda @ryankfu @octavia-squidington-iv