Enable record schema validation using v1 type system; CI uses MSG to start EC2 runners #20439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgao
changed the title
octavia-squidington-iv
added
area/platform
git-phu
approved these changes
Dec 14, 2022
gosusnp
approved these changes
Dec 14, 2022
edgao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreverts #19625, and hardcodes
buildinstead of using${buildDir}. Relevant changes are in the twobuild.gradlefiles, plus the Dockerfile.#19625 was causing the OSS release action to fail (https://github.com/airbytehq/airbyte/actions/runs/3625448595/jobs/6113524965) because the docker build couldn't find
WellKnownTypes.json. This is working properly now.Tested in https://github.com/airbytehq/airbyte/actions/runs/3699371623/jobs/6266680684#step:6:9612 - this action run failed because of an intentional
COPY nonexistent_file.txt, rather than not being able to findWellKnownTypes.json. This action was running against https://github.com/airbytehq/airbyte/pull/20439/files/ba107138acde16cce98a659ecd70fa5ce6705c9b; the subsequent commits are just reverting the CI hacks.Also switches the
start ec2 runneraction to useMSGv0.0.2(which supports Multiple Security Groups). This is useful for being able to SSH onto CI runner instances.