Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Convert the server to micronaut #21132

Merged

Conversation

benmoriceau
Copy link
Contributor

@benmoriceau benmoriceau commented Jan 6, 2023

Reverts #19194

It is blocking a p0 resolution, reverting + there is some CORS issues detected bu @krishnaglick

@benmoriceau benmoriceau requested a review from a team as a code owner January 6, 2023 20:47
@benmoriceau benmoriceau requested a review from a team January 6, 2023 20:47
@octavia-squidington-iv octavia-squidington-iv added area/api Related to the api area/platform issues related to the platform area/server area/worker Related to worker kubernetes labels Jan 6, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 20:53 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 20:54 — with GitHub Actions Inactive
@benmoriceau
Copy link
Contributor Author

/approve-and-merge reason="Revert for deploying a p0"

@octavia-approvington
Copy link
Contributor

Enough! Let's do this
goooooo!

@benmoriceau
Copy link
Contributor Author

/approve-and-merge reason="Revert for deploying a p0"

@benmoriceau
Copy link
Contributor Author

/approve-and-merge reason="Revert for deploying a p0"

@octavia-approvington
Copy link
Contributor

Lets do it!
giddddy-up

@octavia-approvington
Copy link
Contributor

A crack team of mammals has made a decision.
imagine a seal of approval

@benmoriceau benmoriceau enabled auto-merge (squash) January 6, 2023 21:03
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 21:03 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 21:03 — with GitHub Actions Inactive
@benmoriceau benmoriceau changed the title Revert "Convert the server to micronaut" Revert Convert the server to micronaut Jan 6, 2023
@benmoriceau
Copy link
Contributor Author

/approve-and-merge reason="Revert for deploying a p0"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit 31c65f8 into master Jan 6, 2023
@octavia-approvington octavia-approvington deleted the revert-19194-bmoric/convert-health-micronaut branch January 6, 2023 21:08
benmoriceau added a commit that referenced this pull request Jan 6, 2023
benmoriceau added a commit that referenced this pull request Jan 9, 2023
* Revert "Revert "Convert the server to micronaut (#19194)" (#21132)"

This reverts commit 31c65f8.

* Fix the cors

* Fix cloud
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
* Revert "Revert "Convert the server to micronaut (#19194)" (#21132)"

This reverts commit 31c65f8.

* Fix the cors

* Fix cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to the api area/platform issues related to the platform area/server area/worker Related to worker kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants