Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert Convert the server to micronaut" #21133

Merged
merged 6 commits into from
Jan 9, 2023
Merged

Revert "Revert Convert the server to micronaut" #21133

merged 6 commits into from
Jan 9, 2023

Conversation

benmoriceau
Copy link
Contributor

Reverts #21132

@octavia-squidington-iv octavia-squidington-iv added area/api Related to the api area/platform issues related to the platform area/server area/worker Related to worker kubernetes labels Jan 6, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 21:10 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 21:10 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 22:49 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 22:49 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 23:47 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 6, 2023 23:47 — with GitHub Actions Inactive
@benmoriceau benmoriceau marked this pull request as ready for review January 7, 2023 22:54
@benmoriceau benmoriceau requested a review from a team as a code owner January 7, 2023 22:54
@benmoriceau benmoriceau requested a review from a team January 7, 2023 22:54
@benmoriceau benmoriceau temporarily deployed to more-secrets January 7, 2023 23:00 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 7, 2023 23:00 — with GitHub Actions Inactive
krishnaglick
krishnaglick approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm the FE doesn't get CORS errors during dev!

@benmoriceau benmoriceau temporarily deployed to more-secrets January 9, 2023 16:25 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 9, 2023 16:25 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 9, 2023 18:02 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 9, 2023 18:02 — with GitHub Actions Inactive
@benmoriceau benmoriceau merged commit 9adb63c into master Jan 9, 2023
@benmoriceau benmoriceau deleted the revert-21132-revert-19194-bmoric/convert-health-micronaut branch January 9, 2023 18:52
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@benmoriceau @jbfbell
Revert "Revert Convert the server to micronaut" (#21133)
c83b293 
* Revert "Revert "Convert the server to micronaut (#19194)" (#21132)"

This reverts commit 31c65f8.

* Fix the cors

* Fix cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

@gosusnp gosusnp Awaiting requested review from gosusnp

@alovew alovew Awaiting requested review from alovew

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@jdpgrailsdev jdpgrailsdev Awaiting requested review from jdpgrailsdev

Assignees
No one assigned
Labels
area/api Related to the api area/platform issues related to the platform area/server area/worker Related to worker kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmoriceau @krishnaglick @octavia-squidington-iv