-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing vulnerabilities for source-salesforce - Premium support #28021
Fixing vulnerabilities for source-salesforce - Premium support #28021
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mauricioalarcon
cc @alafanechere - as we work to remove Dockerfiles in favor of Dagger, there are some good fixes in this PR |
@mauricioalarcon this change seems to have increased the cc @marcosmarxm |
@alafanechere can you confirm the step it got stuck running in the CI is the same as |
Attempt # 2 - this should replace previous PR
CVE-2022-40897
https://security-tracker.debian.org/tracker/CVE-2023-29383
https://security-tracker.debian.org/tracker/CVE-2023-31484
https://security-tracker.debian.org/tracker/CVE-2016-2781
What
Changed source base image to use
python:3.9-alpine3.18
instead ofslim
- Adjusted to update OS packagesHow
Switched to use alpine based image
Recommended reading order
n/a
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
None expected, just more security
So far nothing breaks and all the test are passing on our side, I've bumped the minor version accordingly
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.0.0.1
Dockerfile
has version0.0.1
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes