Source SalesForce: move to next releaseStage #28243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
artem1205
changed the title
artem1205
changed the title
octavia-squidington-iii
added
the
area/documentation
sherifnada
suggested changes
Jul 20, 2023
airbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py
Show resolved
Hide resolved
sherifnada
reviewed
Jul 24, 2023
airbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py
Outdated
Show resolved
Hide resolved
sherifnada
reviewed
Jul 24, 2023
| (stream_slice or {}).get("start_date", ""), | ||
| (next_page_token or {}).get("start_date", ""), | ||
| ) | ||
| start_date = max((stream_state or {}).get(self.cursor_field, ""), (stream_slice or {}).get("start_date", "")) |
There was a problem hiding this comment.
this should handlet he case where both are "", the default value should be 2017-10-01 for this dev version
There was a problem hiding this comment.
seems like this is an old implementation, we always have a stream slices here and therefore stream_slice.get("start_date") will be enough
artem1205
force-pushed
the
artem1205/source-salesforce-silver-certification
branch
from
4bb15ea
to
bfdc7b6
Compare
sherifnada
reviewed
Jul 24, 2023
airbyte-integrations/connectors/source-salesforce/source_salesforce/source.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
sherifnada
reviewed
Jul 25, 2023
| @@ -1,38 +1,17 @@ | |||
| # Using alpine to remove several vulnerabilities frm slim image | |||
There was a problem hiding this comment.
I reverted the changes in #28021 because it was causing the build time to be 4 hours long. We should revert this if needed until the contributor can find a way to make this faster.
…thub.com:airbytehq/airbyte into artem1205/source-salesforce-silver-certification
…er-certification' into artem1205/source-salesforce-silver-certification
….18" This reverts commit c7e14ac.
sherifnada
reviewed
Jul 26, 2023
| @@ -111,7 +111,8 @@ def generate_streams( | |||
| start_date = config.get( | |||
| "start_date", (datetime.now() - relativedelta(years=cls.START_DATE_OFFSET_IN_YEARS)).strftime(cls.DATETIME_FORMAT) | |||
| ) | |||
| stream = incremental(**streams_kwargs, replication_key=replication_key, start_date=start_date) | |||
| end_date = config.get("end_date") | |||
There was a problem hiding this comment.
should this be end date OR now()?
artem1205
deleted the
artem1205/source-salesforce-silver-certification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve:
How
airbyte_cdkversionRecommended reading order
x.javay.python🚨 User Impact 🚨
no breaking changes
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.