Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: factor git checkout #32801

Closed

Conversation

postamar
Copy link
Contributor

refactor in anticipation of future changes

@postamar postamar requested a review from a team November 24, 2023 17:07
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 27, 2023 4:08pm

Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but nothing to hold this back.

LGTM!

airbyte-ci/connectors/pipelines/pipelines/helpers/git.py Outdated Show resolved Hide resolved
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
FYI I deeply consolidated the local vs remote checkout and diff operations in the context of my hackday project. This project is an attempt to make airbyte-ci able to target any repo. I wont merge this work anytime soon (until this features hits our roadmap).

#32703

@postamar postamar force-pushed the postamar_gt_11-24-airbyte-ci_factor_get_checkout branch 2 times, most recently from 462b291 to be7c940 Compare November 27, 2023 15:42
@postamar postamar force-pushed the postamar_gt_11-24-airbyte-ci_factor_get_checkout branch from 4595e5d to 8418798 Compare November 27, 2023 16:08
@postamar postamar closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants