-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: bump tag, update readme, remove 'nightly_builds' #32806
airbyte-ci: bump tag, update readme, remove 'nightly_builds' #32806
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
20b2931
to
f348a0f
Compare
f348a0f
to
ba268a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💎
async def get_modified_files_since(current_git_branch: str, current_git_revision: str, since: str, is_local: bool = True) -> Set[str]: | ||
# TODO: implement | ||
return await get_modified_files_in_commit(current_git_branch, current_git_revision, is_local) | ||
if is_local: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filling out the helper!
@@ -74,9 +72,30 @@ async def get_modified_files_in_commit(current_git_branch: str, current_git_revi | |||
return await get_modified_files_in_commit_remote(current_git_branch, current_git_revision) | |||
|
|||
|
|||
def get_modified_files_since_local(current_git_revision: str, since: str) -> Set[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd appreciate since
to be a datetime
/ date
object and make the function perform a strftime
to cast it to string.
def get_modified_files_since_local(current_git_revision: str, since: str) -> Set[str]: | ||
airbyte_repo = git.Repo() | ||
diffed_git_revision = airbyte_repo.git.log(current_git_revision, f"--before='{since}'", "--max-count=1", "--pretty=%H").strip() | ||
return get_modified_files_local(current_git_revision, diffed_git_revision) | ||
|
||
|
||
async def get_modified_files_since_remote(current_git_branch: str, current_git_revision: str, since: str) -> Set[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find these two helpers being used? Or am I missing coffee? If they're not used yet I'm not sure the version bump should happen in this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing coffee. In any case I just got rid of them. I'm going to merge this stack just to fix the stacked pull request behaviour.
e9c2a7d
to
850daee
Compare
ba268a8
to
7b5e8e3
Compare
e97b5fd
to
54307a1
Compare
541c18d
to
210b58e
Compare
138055e
to
71c4cb7
Compare
11d0983
to
d64321e
Compare
/approve-and-merge reason="blocked by docker pull rate limit" |
This PR gets rid of the "nightly_builds" CI_CONTEXT value.
This PR changes the behaviour of --modified when CI_CONTEXT is "nightly_builds" or "weekly_builds".Presently, when--modified
and either of those CI_CONTEXT values are set, airbyte-ci determines which connectors have been modified by looking only at which connectors were changed in whatever happens to be the HEAD commit on the master branch at that time.This is certainly not what anyone wants.
This PR changes this to look at the connectors changed in HEAD and all of its ancestors up until a certain date.This cutoff date is '1 day ago' for nightlies and '1 week ago' for weeklies.