airbyte-ci: improve git diff comparison #37616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
octavia-squidington-iii
added
area/connectors
This was referenced Apr 26, 2024
alafanechere
force-pushed
the
augustin/04-26-airbyte-ci_improve_git_diff_comparison
branch
from
e4cd71d
to
61f047d
Compare
alafanechere
deleted the
augustin/04-26-airbyte-ci_improve_git_diff_comparison
branch
2 tasks
erohmensing
added a commit
that referenced
this pull request
Apr 26, 2024
This reverts commit a8ec6d0.
erohmensing
added a commit
that referenced
this pull request
Apr 26, 2024
alafanechere
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
airbyte-ciretrieves the list of modified files in the branch by running agit diffbetweenmasterand the current branch.When running on forks (with custom
--git-repo-url) it was not clear ifmastermeant the fork's master orairbyte's repo master.I changed the in container git and diff logic to always fetch airbyte's master.