Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "airbyte-ci: improve git diff comparison (#37616)" #37641

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Apr 26, 2024

This reverts commit a8ec6d0.

Adding support for forks seems to have messed with our publishing pipeline locally. We need to fix this so that we can continue to do things on forks, but this lets us continue to publish, which is very important for on call fixes, in the meantime

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 10:14pm

@erohmensing erohmensing marked this pull request as ready for review April 26, 2024 22:14
@erohmensing erohmensing requested a review from a team as a code owner April 26, 2024 22:14
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock for the weekend. Thank you for catching that.

@erohmensing
Copy link
Contributor Author

I didn't catch anything, @bnchrch did! But thank you, will merge

@erohmensing erohmensing merged commit 76a2768 into master Apr 26, 2024
38 checks passed
@erohmensing erohmensing deleted the ella/revert branch April 26, 2024 22:35
alafanechere added a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants