refactor import / export endpoints to use the same code path as auto … #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
force-pushed
the
cgardens/import_use_same_code_path
branch
from
16ac076
to
0ddc85e
Compare
tuliren
reviewed
Jul 26, 2021
| @@ -75,7 +76,7 @@ public static ConfigPersistence createWithValidation(final Path storageRoot) thr | |||
|
|
|||
| public FileSystemConfigPersistence(final Path storageRoot) { | |||
| this.storageRoot = storageRoot; | |||
| this.configRoot = storageRoot.resolve(CONFIG_DIR); | |||
| this.configRoot = Exceptions.toRuntime(() -> Files.createDirectories(storageRoot.resolve(CONFIG_DIR))); | |||
There was a problem hiding this comment.
@cgardens, this is only needed for testing, right?
In production the config directory should not be created by this constructor. This is because when the server launches, it is possible that the config volume is not ready yet. It should wait for the config volume, instead of creating this directory itself. We have this logic in the createWithValidation method.
This is the PR with more details: #4835.
There was a problem hiding this comment.
ah. make sense. i'll revert this part out.
There was a problem hiding this comment.
fixed it here in this PR: #4987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…migration
What