Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add back seeds for config import #5209

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Aug 4, 2021

What

How

Recommended reading order

  1. ConfigDumpImporter.java
  2. The rest.

@github-actions github-actions bot added the area/platform issues related to the platform label Aug 4, 2021
@tuliren tuliren changed the title Liren/fix seed after config import 🐛 Add back seeds for config import Aug 4, 2021
if (seedPath.isPresent()) {
seed = getSeed(seedPath.get());
} else {
seed = new HashMap<>();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the root cause of the bug.

Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@tuliren
Copy link
Contributor Author

tuliren commented Aug 5, 2021

I just updated the PR description. The unit test for this change is complicated. I will try to test it in a separate PR. If that's not trivial, the seeding logics will be refactored very soon any way.

@cgardens
Copy link
Contributor

cgardens commented Aug 5, 2021

legit. i'm definitely cool with it if you want to do less test writing now if you know you are about to refactor it and think that test writing then will be more efficient.

@tuliren tuliren merged commit 8f75080 into master Aug 5, 2021
@tuliren tuliren deleted the liren/fix-seed-after-config-import branch August 5, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Configuration removes all available connectors
2 participants