🎉 Source Google Workspace Admin: use SAT #6878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
|
/test connector=connectors/source-google-workspace-admin-reports
|
gaart
requested review from
vitaliizazmic
and removed request for
vitaliizazmic
keu
reviewed
Oct 13, 2021
| basic_read: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| validate_schema: False |
There was a problem hiding this comment.
could you please add a comment explaining why we have skipped this check?
keu
reviewed
Oct 13, 2021
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
here and in other places we need new line character
keu
reviewed
Oct 13, 2021
|
|
||
| | Version | Date | Pull Request | Subject | | ||
| | :------ | :-------- | :----- | :------ | | ||
| | 0.1.5 | 2021-10-07 | [6878](https://github.com/airbytehq/airbyte/pull/6878) | Implement SAT | |
There was a problem hiding this comment.
Suggested change
| | 0.1.5 | 2021-10-07 | [6878](https://github.com/airbytehq/airbyte/pull/6878) | Implement SAT | | |
| | 0.1.5 | 2021-10-07 | [6878](https://github.com/airbytehq/airbyte/pull/6878) | Integrate SAT | |
keu
reviewed
Oct 13, 2021
| @@ -48,7 +46,7 @@ | |||
| "type": "string" | |||
| }, | |||
| "events": { | |||
| "type": "array", | |||
| "type": "object", | |||
| "items": [ | |||
There was a problem hiding this comment.
if it is an object can it have items?
|
/test connector=connectors/source-google-workspace-admin-reports
|
|
/test connector=connectors/source-google-workspace-admin-reports
|
|
/test connector=connectors/source-google-workspace-admin-reports
|
keu
approved these changes
Oct 22, 2021
vitaliizazmic
approved these changes
Oct 22, 2021
| { | ||
| "stream": { | ||
| "name": "admin", | ||
| "json_schema": { |
There was a problem hiding this comment.
I think, we can leave it empty.
| @@ -1,8 +1,17 @@ | |||
| { | |||
| "drive": { | |||
| "time": "2021-04-04T22:01:22.313Z" | |||
| "time": "2121-04-04T22:01:22.313Z" | |||
There was a problem hiding this comment.
Do we need abnormal state in sample?
|
/test connector=connectors/source-google-workspace-admin-reports
|
|
/test connector=connectors/source-google-workspace-admin-reports
|
sherifnada
approved these changes
Oct 29, 2021
| "type": "string" | ||
| }, | ||
| "multiValue": { |
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
|
/test connector=connectors/source-google-workspace-admin-reports
|
|
/publish connector=connectors/source-google-workspace-admin-reports
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* Add SAT * Upd changelog * Refactor * Upd acceptance-test-config * Upd schemas * Update docs Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6820
Adds SAT and stops using the old integration tests
Pre-merge Checklist
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here