🎉 Source Google Workspace Admin: use SAT #6878
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # See [Source Acceptance Tests](https://docs.airbyte.io/connector-development/testing-connectors/source-acceptance-tests-reference) | ||
| # for more information about how to configure these tests | ||
| connector_image: airbyte/source-google-workspace-admin-reports:dev | ||
| tests: | ||
| spec: | ||
| - spec_path: "source_google_workspace_admin_reports/spec.json" | ||
| connection: | ||
| - config_path: "secrets/config.json" | ||
| status: "succeed" | ||
| - config_path: "integration_tests/invalid_config.json" | ||
| status: "failed" | ||
| discovery: | ||
| - config_path: "secrets/config.json" | ||
| basic_read: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| empty_streams: ["admin"] | ||
| full_refresh: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| incremental: | ||
| - config_path: "secrets/config.json" | ||
| configured_catalog_path: "integration_tests/configured_catalog.json" | ||
| future_state_path: "integration_tests/abnormal_state.json" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/usr/bin/env sh | ||
|
|
||
| # Build latest connector image | ||
| docker build . -t $(cat acceptance-test-config.yml | grep "connector_image" | head -n 1 | cut -d: -f2):dev | ||
|
|
||
| # Pull latest acctest image | ||
| docker pull airbyte/source-acceptance-test:latest | ||
|
|
||
| # Run | ||
| docker run --rm -it \ | ||
| -v /var/run/docker.sock:/var/run/docker.sock \ | ||
| -v /tmp:/tmp \ | ||
| -v $(pwd):/test_input \ | ||
| airbyte/source-acceptance-test \ | ||
| --acceptance-test-config /test_input | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,14 @@ | ||
| plugins { | ||
| id 'airbyte-python' | ||
| id 'airbyte-docker' | ||
| id 'airbyte-source-acceptance-test' | ||
| } | ||
|
|
||
| airbytePython { | ||
| moduleDirectory 'source_google_workspace_admin_reports' | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation files(project(':airbyte-integrations:bases:source-acceptance-test').airbyteDocker.outputs) | ||
| implementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs) | ||
| } |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "drive": { | ||
| "time": "2121-04-04T22:01:22.313Z" | ||
| }, | ||
| "oauth_tokens": { | ||
| "time": "2121-04-05T03:06:30.849Z" | ||
| }, | ||
| "admin": { | ||
| "time": "2121-04-05T03:06:30.849Z" | ||
| }, | ||
| "logins": { | ||
| "time": "2121-04-05T03:06:30.849Z" | ||
| }, | ||
| "mobile": { | ||
| "time": "2121-04-05T03:06:30.849Z" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # | ||
| # Copyright (c) 2021 Airbyte, Inc., all rights reserved. | ||
| # | ||
|
|
||
|
|
||
| import pytest | ||
|
|
||
| pytest_plugins = ("source_acceptance_test.plugin",) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session", autouse=True) | ||
| def connector_setup(): | ||
| """This fixture is a placeholder for external resources that acceptance test might require.""" | ||
| yield |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| { | ||
| "streams": [ | ||
| { | ||
| "stream": { | ||
| "name": "admin", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": ["incremental"], | ||
| "source_defined_cursor": true, | ||
| "default_cursor_field": ["time"] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "cursor_field": ["time"], | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "drive", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": ["incremental"], | ||
| "source_defined_cursor": true, | ||
| "default_cursor_field": ["time"] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "cursor_field": ["time"], | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "logins", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": ["incremental"], | ||
| "source_defined_cursor": true, | ||
| "default_cursor_field": ["time"] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "cursor_field": ["time"], | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "mobile", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": ["incremental"], | ||
| "source_defined_cursor": true, | ||
| "default_cursor_field": ["time"] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "cursor_field": ["time"], | ||
| "destination_sync_mode": "append" | ||
| }, | ||
| { | ||
| "stream": { | ||
| "name": "oauth_tokens", | ||
| "json_schema": {}, | ||
| "supported_sync_modes": ["incremental"], | ||
| "source_defined_cursor": true, | ||
| "default_cursor_field": ["time"] | ||
| }, | ||
| "sync_mode": "incremental", | ||
| "cursor_field": ["time"], | ||
| "destination_sync_mode": "append" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "credentials_json": "{\n \"type\": \"service_account\"}\n", | ||
| "email": "test_email", | ||
| "lookback": 0 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # This file is autogenerated -- only edit if you know what you are doing. Use setup.py for declaring dependencies. | ||
| -e ../../bases/airbyte-protocol | ||
| -e ../../bases/base-python | ||
| -e ../../bases/source-acceptance-test | ||
| -e . |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below the events field has a dynamic structure, that is, this field is returned as an array of objects with different subfields and variable nesting. Is this okay to replace it with an
object?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could explain more about "dynamic" schema? Just asking because we are losing a lot of specificity in the data which makes it harder to consume. Are these essentially
oneOfs? Was the existing schema incorrect?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada The
parametersfield has a list of objects with variable payload (different objects within the same array at the same point of time), in some cases there are deeply nested structures, and the inner items are different from each other, so theoneOfis not applicable, theanyOfpossibly could workThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just worried this will cause breaking changes to the schema. This is a pretty important stream (events are potentially the most important resource in this stream) so like described in UX handbook sections
Describe output schemas as completely and reliably as possibleandBe very cautious about breaking changes to output schemas, it is probably worth attempting to describe the schema as completely as possible. Do you have any insight into how doable this is? @gaartThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada schema updated, nested fields added