Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7243 🎉 Source Shopify: implement OAuth Java part #7245

Closed
wants to merge 5 commits into from
Closed

#7243 🎉 Source Shopify: implement OAuth Java part #7245

wants to merge 5 commits into from

Conversation

alexandr-shegeda
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@alexandr-shegeda alexandr-shegeda linked an issue Oct 21, 2021 that may be closed by this pull request
Source Shopify: implement oauth2 java-part #7243
Closed
@github-actions github-actions bot added area/api Related to the api area/connectors Connector related issues labels Oct 21, 2021
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets October 21, 2021 17:46 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets October 21, 2021 17:53 Inactive
@alexandr-shegeda
Merge branch 'master' into asheg/source-shopify-oauth-java-part
9193298 
# Conflicts:
#	airbyte-oauth/src/main/java/io/airbyte/oauth/OAuthImplementationFactory.java
#	airbyte-oauth/src/test-integration/java/io.airbyte.oauth.flows/FacebookMarketingOAuthFlowIntegrationTest.java
#	airbyte-oauth/src/test-integration/java/io.airbyte.oauth.flows/SalesforceOAuthFlowIntegrationTest.java
#	airbyte-server/src/main/java/io/airbyte/server/handlers/OAuthHandler.java
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets October 21, 2021 18:03 Inactive
@cgardens cgardens added area/platform issues related to the platform and removed area/core labels Oct 23, 2021
@bazarnov
Copy link
Collaborator

Closed, because of too much conflicts with master, created new PR here for this.

@bazarnov bazarnov closed this Jan 19, 2022
@bazarnov bazarnov removed a link to an issue Jan 19, 2022
Source Shopify: implement oauth2 java-part #7243
Closed
@swyxio swyxio deleted the asheg/source-shopify-oauth-java-part branch October 12, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/api Related to the api area/connectors Connector related issues area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandr-shegeda @bazarnov @cgardens