Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Shopify: implement Oauth2.0 for Airbyte-Cloud #9591

Merged
merged 7 commits into from
Jan 19, 2022

Conversation

bazarnov
Copy link
Collaborator

What

Resolves: #7243

How

  • added java part ShopifyOAuthFlow.class

🚨 User Impact 🚨

  • User have to update the connector to 0.1.28 version.
  • User have to update the connector's schemas, after version update.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Jan 19, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Jan 19, 2022
@bazarnov bazarnov temporarily deployed to more-secrets January 19, 2022 10:46 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 19, 2022
@bazarnov bazarnov temporarily deployed to more-secrets January 19, 2022 10:48 Inactive
@bazarnov bazarnov linked an issue Jan 19, 2022 that may be closed by this pull request
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jan 19, 2022

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1717572479
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1717572479
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      2     0%
	 source_shopify/auth.py           20     20     0%
	 source_shopify/source.py        250    250     0%
	 source_shopify/transform.py      58     58     0%
	 source_shopify/utils.py          57     57     0%
	 -------------------------------------------------
	 TOTAL                           387    387     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                          Stmts   Miss  Cover
	 -------------------------------------------------
	 source_shopify/__init__.py        2      0   100%
	 source_shopify/auth.py           20     11    45%
	 source_shopify/source.py        250    102    59%
	 source_shopify/transform.py      58      3    95%
	 source_shopify/utils.py          57      6    89%
	 -------------------------------------------------
	 TOTAL                           387    122    68%

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor comment.

Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add integration config for checking of backward compatibility?

@bazarnov
Copy link
Collaborator Author

Could you add integration config for checking of backward compatibility?

It's already there, the python changes for source-shopify were introduced way before this PR, with version 0.1.19, the acceptance-test-config.yml, where this facts are tested. Please check this PR for more info: #6951

@bazarnov bazarnov requested a review from antixar January 19, 2022 18:14
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please publish your changes

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jan 19, 2022

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1719625010
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1719625010

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 19, 2022 18:35 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 19, 2022 19:26 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 19, 2022 20:19 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets January 19, 2022 20:42 Inactive
@bazarnov bazarnov merged commit 8b149e8 into master Jan 19, 2022
@bazarnov bazarnov deleted the bazarnov/shopify-oauth branch January 19, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Shopify connector on Cloud Source Shopify: implement oauth2 java-part
4 participants