🐛 Source Jira: Fix normalization step error #7408

htrueman · 2021-10-27T11:09:57Z

What

Closes #6016

How

Fix stream schemas.
Fix streams.py stream reading and codestyle.
Fix acceptance-test-config.yml.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

Fix streams.py. Fix acceptance test config.

…e-normalization-step-error

CLAassistant · 2021-10-27T11:10:05Z

All committers have signed the CLA.

htrueman · 2021-10-27T13:09:13Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1390254581
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1390254581
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-jira/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 Name                      Stmts   Miss  Cover
	   self._warn("No data was collected.", slug="no-data-collected")
	 ---------------------------------------------
	 source_jira/__init__.py       2      2     0%
	 source_jira/source.py        34     34     0%
	 source_jira/streams.py      542    542     0%
	 ---------------------------------------------
	 TOTAL                       578    578     0%

airbyte-integrations/connectors/source-jira/source_jira/streams.py

…ira-source-normalization-step-error

sherifnada · 2021-10-28T16:51:09Z

airbyte-integrations/connectors/source-jira/acceptance-test-config.yml

@@ -23,10 +23,12 @@ tests:
      configured_catalog_path: "integration_tests/issue_worklogs_configured_catalog.json"
    - config_path: "secrets/config.json"
      configured_catalog_path: "integration_tests/projects_configured_catalog.json"
+      empty_streams: ["project_permission_schemes"]


can you create an issue to populate these empty streams if they are not populated anywhere?

Sure, see #7488

airbyte-integrations/connectors/source-jira/source_jira/schemas/sprint_issues.json

airbyte-integrations/connectors/source-jira/build.gradle

htrueman · 2021-10-29T11:08:28Z

/publish connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1398681495
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1398681495

* Fix schemas. Fix streams.py. Fix acceptance test config. * Delete sample_files dir. * Remove `sample_files` references. * Update `jira.md`. * Fix build.gradle * Fix stream_slice initialization * Remove unnecessary build.gradle dependencies * Bump docker version

htrueman added 2 commits October 27, 2021 14:04

Fix schemas.

4f1e385

Fix streams.py. Fix acceptance test config.

Merge remote-tracking branch 'origin/master' into htrueman/jira-sourc…

e2d50db

…e-normalization-step-error

htrueman added this to the Connectors 2021-10-29 milestone Oct 27, 2021

htrueman requested review from avida, Zirochkaa and yevhenii-ldv October 27, 2021 11:09

htrueman self-assigned this Oct 27, 2021

github-actions bot added the area/connectors Connector related issues label Oct 27, 2021

Delete sample_files dir.

c791022

htrueman temporarily deployed to more-secrets October 27, 2021 11:14 Inactive

jrhizor temporarily deployed to more-secrets October 27, 2021 11:14 Inactive

Remove sample_files references.

faddca1

htrueman temporarily deployed to more-secrets October 27, 2021 11:17 Inactive

jrhizor temporarily deployed to more-secrets October 27, 2021 11:18 Inactive

Update jira.md.

cbb4ae6

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 27, 2021

htrueman temporarily deployed to more-secrets October 27, 2021 11:25 Inactive

jrhizor temporarily deployed to more-secrets October 27, 2021 11:26 Inactive

jrhizor temporarily deployed to more-secrets October 27, 2021 12:39 Inactive

Fix build.gradle

3390d93

htrueman temporarily deployed to more-secrets October 27, 2021 13:10 Inactive

jrhizor temporarily deployed to more-secrets October 27, 2021 13:11 Inactive

avida reviewed Oct 27, 2021

View reviewed changes

airbyte-integrations/connectors/source-jira/source_jira/streams.py Outdated Show resolved Hide resolved

avida reviewed Oct 27, 2021

View reviewed changes

airbyte-integrations/connectors/source-jira/source_jira/streams.py Outdated Show resolved Hide resolved

htrueman added 2 commits October 27, 2021 18:36

Merge branch 'master' of github.com:airbytehq/airbyte into htrueman/j…

c44691d

…ira-source-normalization-step-error

Fix stream_slice initialization

003c885

htrueman requested a review from avida October 27, 2021 16:43

htrueman temporarily deployed to more-secrets October 27, 2021 16:45 Inactive

avida approved these changes Oct 28, 2021

View reviewed changes

htrueman requested a review from sherifnada October 28, 2021 13:09

sherifnada approved these changes Oct 28, 2021

View reviewed changes

htrueman added 2 commits October 29, 2021 14:02

Remove unnecessary build.gradle dependencies

12d7441

Bump docker version

35dafab

htrueman temporarily deployed to more-secrets October 29, 2021 11:07 Inactive

jrhizor temporarily deployed to more-secrets October 29, 2021 11:12 Inactive

htrueman mentioned this pull request Oct 29, 2021

🎉 Source Jira: Fill empty streams with data #7488

Closed

htrueman merged commit 9c78351 into master Oct 29, 2021

htrueman deleted the htrueman/jira-source-normalization-step-error branch October 29, 2021 11:19

jrhizor mentioned this pull request Nov 1, 2021

Bump Airbyte version from 0.30.23-alpha to 0.30.24-alpha #7532

Merged

vitaliizazmic mentioned this pull request Nov 29, 2021

[Story] Completely update all base-python connectors, use CDK package instead #7242

Closed

36 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Jira: Fix normalization step error #7408

🐛 Source Jira: Fix normalization step error #7408

htrueman commented Oct 27, 2021

CLAassistant commented Oct 27, 2021 •

edited

Loading

htrueman commented Oct 27, 2021 •

edited by github-actions bot

Loading

sherifnada Oct 28, 2021

htrueman Oct 29, 2021

htrueman commented Oct 29, 2021 •

edited by github-actions bot

Loading

🐛 Source Jira: Fix normalization step error #7408

🐛 Source Jira: Fix normalization step error #7408

Conversation

htrueman commented Oct 27, 2021

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Oct 27, 2021 • edited Loading

htrueman commented Oct 27, 2021 • edited by github-actions bot Loading

sherifnada Oct 28, 2021

Choose a reason for hiding this comment

htrueman Oct 29, 2021

Choose a reason for hiding this comment

htrueman commented Oct 29, 2021 • edited by github-actions bot Loading

CLAassistant commented Oct 27, 2021 •

edited

Loading

htrueman commented Oct 27, 2021 •

edited by github-actions bot

Loading

htrueman commented Oct 29, 2021 •

edited by github-actions bot

Loading