Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Jira: Fix normalization step error #7408

Merged
merged 10 commits into from
Oct 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"sourceDefinitionId": "68e63de2-bb83-4c7e-93fa-a8a9051e3993",
"name": "Jira",
"dockerRepository": "airbyte/source-jira",
"dockerImageTag": "0.2.13",
"dockerImageTag": "0.2.14",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/jira",
"icon": "jira.svg"
}
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@
- name: Jira
sourceDefinitionId: 68e63de2-bb83-4c7e-93fa-a8a9051e3993
dockerRepository: airbyte/source-jira
dockerImageTag: 0.2.13
dockerImageTag: 0.2.14
documentationUrl: https://docs.airbyte.io/integrations/sources/jira
icon: jira.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.13
LABEL io.airbyte.version=0.2.14
LABEL io.airbyte.name=airbyte/source-jira
6 changes: 3 additions & 3 deletions airbyte-integrations/connectors/source-jira/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ From the Airbyte repository root, run:
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/jira)
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_jira/spec.json` file.
Note that the `secrets` directory is gitignored by default, so there is no danger of accidentally checking in sensitive information.
See `sample_files/sample_config.json` for a sample config file.
See `integration_tests/sample_config.json` for a sample config file.

**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source jira test creds`
and place them into `secrets/config.json`.
Expand All @@ -50,7 +50,7 @@ and place them into `secrets/config.json`.
python main.py spec
python main.py check --config secrets/config.json
python main.py discover --config secrets/config.json
python main.py read --config secrets/config.json --catalog sample_files/configured_catalog.json
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Unit Tests
Expand Down Expand Up @@ -80,7 +80,7 @@ Then run any of the connector commands as follows:
docker run --rm airbyte/source-jira:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-jira:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-jira:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/sample_files:/sample_files airbyte/source-jira:dev read --config /secrets/config.json --catalog /sample_files/configured_catalog.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-jira:dev read --config secrets/config.json --catalog integration_tests/configured_catalog.json
```

### Integration Tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@ tests:
configured_catalog_path: "integration_tests/issue_worklogs_configured_catalog.json"
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/projects_configured_catalog.json"
empty_streams: ["project_permission_schemes"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create an issue to populate these empty streams if they are not populated anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, see #7488

- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/workflows_configured_catalog.json"
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: ["epics", "screen_tab_fields", "sprint_issues", "sprints"]
# incremental:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/inc_configured_catalog.json"
Expand Down
14 changes: 1 addition & 13 deletions airbyte-integrations/connectors/source-jira/build.gradle
Original file line number Diff line number Diff line change
@@ -1,21 +1,9 @@
plugins {
id 'airbyte-python'
id 'airbyte-docker'
id 'airbyte-standard-source-test-file'
id 'airbyte-source-acceptance-test'
}

airbytePython {
moduleDirectory 'source_jira'
}

airbyteStandardSourceTestFile {
specPath = "source_jira/spec.json"
configPath = "secrets/config.json"
configuredCatalogPath = "sample_files/configured_catalog.json"
}


dependencies {
implementation files(project(':airbyte-integrations:bases:base-standard-source-test-file').airbyteDocker.outputs)
implementation files(project(':airbyte-integrations:bases:base-python').airbyteDocker.outputs)
}
Loading