-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Outreach #7507
🎉 New Source: Outreach #7507
Conversation
Hey @lgomezm thanks for the contribution 🔥. Can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes otherwise LGTM
airbyte-integrations/connectors/source-outreach/source_outreach/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-outreach/source_outreach/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-outreach/source_outreach/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-outreach/source_outreach/source.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-outreach/source_outreach/source.py
Outdated
Show resolved
Hide resolved
Hi @harshithmullapudi. I've just addressed your comments. Please take a look again when you get a chance. Thanks for reviewing! |
Hey @lgomezm due to some restriction on Outreach end our credentials are returning 429 in later tests. Do you have some take on this ? |
Hi @harshithmullapudi. Yes, unfortunately it fails intermittently beacuse of |
Hello @lgomezm ! Sorry to not finished your contribution before the date stipulated in the contest. All contributions made before 15-November are eligible to receive the award. We're trying to review your contribution as soon as possible. |
* Generated connector source code * Added streams: prospect, sequence, sequenceState * Updated spec and schemas * Removed print statement * Added unit tests * Updated acceptance test files * Updated spec * Ran gradlew format * Added comments * Added Outreach source documentation
What
Outreach
as new source. Fixes Outreach.io as source of data #3627How
prospects
,sequences
,sequence_states
.Recommended reading order
spec.json
.schemas/*.json
.source.py
Tests Run
Integration tests
Unit tests
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes