Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Outreach #7507

Merged

Conversation

lgomezm
Copy link
Contributor

@lgomezm lgomezm commented Nov 1, 2021

What

How

  • Implements OAuth authentication.
  • Supports both full refresh and incremental syncs.
  • Supported streams: prospects, sequences, sequence_states.
  • New streams can be added easily.

Recommended reading order

  1. spec.json.
  2. Schemas in schemas/*.json.
  3. source.py

Tests Run

Integration tests

Screen Shot 2021-10-31 at 9 20 12 PM

Unit tests

Screen Shot 2021-10-31 at 9 23 01 PM

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 1, 2021
@harshithmullapudi
Copy link
Contributor

Hey @lgomezm thanks for the contribution 🔥. Can you run ./gradlew format

Copy link
Contributor

@harshithmullapudi harshithmullapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes otherwise LGTM

@lgomezm
Copy link
Contributor Author

lgomezm commented Nov 2, 2021

Hi @harshithmullapudi. I've just addressed your comments. Please take a look again when you get a chance. Thanks for reviewing!

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 3, 2021
@harshithmullapudi harshithmullapudi temporarily deployed to more-secrets November 11, 2021 08:24 Inactive
@harshithmullapudi
Copy link
Contributor

Hey @lgomezm due to some restriction on Outreach end our credentials are returning 429 in later tests. Do you have some take on this ?

@lgomezm
Copy link
Contributor Author

lgomezm commented Nov 14, 2021

Hey @lgomezm due to some restriction on Outreach end our credentials are returning 429 in later tests. Do you have some take on this ?

Hi @harshithmullapudi. Yes, unfortunately it fails intermittently beacuse of HTTP 429: Too many requests. One work around I use to check failed scenarios is run separately those cases that failed because of that error, with something like $ python -m pytest integration_tests -p integration_tests.acceptance -k 'test_two_sequential_reads'. That command runs the test case called test_two_sequential_reads.

@marcosmarxm
Copy link
Member

Hello @lgomezm ! Sorry to not finished your contribution before the date stipulated in the contest. All contributions made before 15-November are eligible to receive the award. We're trying to review your contribution as soon as possible.

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* Generated connector source code

* Added streams: prospect, sequence, sequenceState

* Updated spec and schemas

* Removed print statement

* Added unit tests

* Updated acceptance test files

* Updated spec

* Ran gradlew format

* Added comments

* Added Outreach source documentation
@prasrvenkat prasrvenkat deleted the lgomez/outreach_connector branch January 12, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/outreach
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outreach.io as source of data
6 participants