Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source: Outreach connector #5

Closed
wants to merge 10 commits into from
Closed

Source: Outreach connector #5

wants to merge 10 commits into from

Conversation

lgomezm
Copy link

@lgomezm lgomezm commented Oct 26, 2021

Description of the change

This PR adds a new source connector for Outreach. I'll update it to include tests.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (code refactor or system optimization that improves performance)

Checklists

Development

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

@prasrvenkat
Copy link

If you are going to add tests and handle checklist items feel free to directly raise against them and tag that issue
airbytehq#3627

Kopiczek
Kopiczek approved these changes Nov 3, 2021
View reviewed changes
Copy link

@Kopiczek Kopiczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgomezm
Copy link
Author

lgomezm commented Nov 26, 2021

Closing, because airbytehq#7507 was already merged.

@lgomezm lgomezm closed this Nov 26, 2021
@prasrvenkat prasrvenkat deleted the lgomez/outreach_connector branch January 12, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kopiczek Kopiczek Kopiczek approved these changes

@fredsadaghiani fredsadaghiani Awaiting requested review from fredsadaghiani

@matbhz matbhz Awaiting requested review from matbhz

@prasrvenkat prasrvenkat Awaiting requested review from prasrvenkat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgomezm @prasrvenkat @Kopiczek