Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Postgres: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8657

Closed
wants to merge 2 commits into from
Closed

🐛 Source Postgres: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8657

wants to merge 2 commits into from

Conversation

yurii-bidiuk
Copy link
Contributor

@yurii-bidiuk yurii-bidiuk commented Dec 9, 2021 •
edited
Loading

What

Fixes #4357

How

Set type "array" for a catalog when the column's JDBC type is an array.

Recommended reading order

  1. PostgresSourceOperations.java
  2. JsonToAvroSchemaConverter.java

User Impact

These changes should not impact the end-user. This PR sets JSON schema type as "array" for DB values that have JDBCType.ARRAY. Before it was set as "string.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker CDK Connector Development Kit kubernetes labels Dec 9, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot removed area/worker Related to worker area/documentation Improvements or additions to documentation area/platform issues related to the platform kubernetes CDK Connector Development Kit area/server area/scheduler area/frontend labels Dec 9, 2021
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets December 9, 2021 11:52 Inactive
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets December 9, 2021 11:54 Inactive
@yurii-bidiuk yurii-bidiuk linked an issue Dec 9, 2021 that may be closed by this pull request
Bigquery destination SCD table does not work with array type from source Postgres table #4357
Closed
@alexandr-shegeda alexandr-shegeda linked an issue Dec 9, 2021 that may be closed by this pull request
Json -> Avro / Parquet schema convert should support array field without items #7939
Closed
alexandr-shegeda
alexandr-shegeda reviewed Dec 9, 2021
View reviewed changes
...postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSourceOperations.java
@@ -127,6 +127,7 @@ public JsonSchemaPrimitive getJsonType(final JDBCType jdbcType) {
case BOOLEAN -> JsonSchemaPrimitive.BOOLEAN;
case TINYINT, SMALLINT, INTEGER, BIGINT, FLOAT, DOUBLE, REAL, NUMERIC, DECIMAL -> JsonSchemaPrimitive.NUMBER;
case BLOB, BINARY, VARBINARY, LONGVARBINARY -> JsonSchemaPrimitive.STRING_BINARY;
case ARRAY -> JsonSchemaPrimitive.ARRAY;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do the same for other sources?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandr-shegeda done in #8749

@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets December 13, 2021 09:23 Inactive
This was unlinked from issues Dec 13, 2021
Bigquery destination SCD table does not work with array type from source Postgres table #4357
Closed
Json -> Avro / Parquet schema convert should support array field without items #7939
Closed
@yurii-bidiuk
Copy link
Contributor Author

replaced with #8749

@swyxio swyxio deleted the bidiuk/fix-postgres-array branch October 12, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda left review comments

@etsybaev etsybaev Awaiting requested review from etsybaev

@sashaNeshcheret sashaNeshcheret Awaiting requested review from sashaNeshcheret

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurii-bidiuk @CLAassistant @alexandr-shegeda