🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8749

yurii-bidiuk · 2021-12-13T14:17:56Z

What

How

Set type "array" for a catalog when the column's JDBC type is an array. Added mapping for array type.

🚨 User Impact 🚨

This PR sets JSON schema type as "array" for DB values that have JDBCType.ARRAY. Before it was set as "string. Parsed value for all arrays will be like ["value1","value2","value3"]

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

...-s3/src/main/java/io/airbyte/integrations/destination/s3/avro/JsonToAvroSchemaConverter.java

tuliren

Looks good in general, except for the comments about json / avro schema converter.

tuliren

Thanks. The unit tests will fail currently, because the object converter does not know to auto convert unknown array to an array of string. I will make a change in the Json object converter accordingly.

...tination-s3/src/test/resources/parquet/json_schema_converter/json_conversion_test_cases.json

tuliren · 2021-12-14T03:45:40Z

I created PR airbytehq/json-avro-converter#10. @yurii-bidiuk, please take a look. I just added to that repo, but I could not tag you directly as a reviewer yet.

tuliren · 2021-12-14T20:04:07Z

There was a bug in my Json / Avro object converter PR. I am working on a fix.

tuliren · 2021-12-15T00:54:32Z

The bug should have been fixed (airbytehq/json-avro-converter#11). I have also updated the test case in this PR.

alexandr-shegeda

LGTM

* Add skeleton to support all postgres types * Consolidate type tests * Fix corner cases * Bump postgres version * Add tests for time and timetz * Format code * Revert date to timestamp * Update comment * Fix unit tests * 🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY (#8749) * support array for jdbc sources * fixed PR comments, added test cases * added more elements for test case * Fix test case * add array test case for JdbcSourceOperations Co-authored-by: Liren Tu <tuliren.git@outlook.com> * Revert changes to support special number values Postgres source cannot handle these special values yet See https://github.com/airbytehq/airbyte/issues/8902 * Revert infinity and nan assertion in unit tests This reverts commit 3bee7d1. * Update documentation * Bump postgres source version in seed Co-authored-by: Yurii Bidiuk <35812734+yurii-bidiuk@users.noreply.github.com>

tuliren · 2021-12-20T08:01:58Z

@yurii-bidiuk, this change has been merged to master together with PR #8726. My PR only publishes Postgres. Can you take care of the publication of the other databases that are affected by this array change?

yurii-bidiuk · 2021-12-20T09:48:08Z

@tuliren ok, I will publish it in separate PR

* bump versions * fix tests for cockroachdb * update changelog

* Add skeleton to support all postgres types * Consolidate type tests * Fix corner cases * Bump postgres version * Add tests for time and timetz * Format code * Revert date to timestamp * Update comment * Fix unit tests * 🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY (airbytehq#8749) * support array for jdbc sources * fixed PR comments, added test cases * added more elements for test case * Fix test case * add array test case for JdbcSourceOperations Co-authored-by: Liren Tu <tuliren.git@outlook.com> * Revert changes to support special number values Postgres source cannot handle these special values yet See https://github.com/airbytehq/airbyte/issues/8902 * Revert infinity and nan assertion in unit tests This reverts commit 3bee7d1. * Update documentation * Bump postgres source version in seed Co-authored-by: Yurii Bidiuk <35812734+yurii-bidiuk@users.noreply.github.com>

support array for jdbc sources

16198d8

yurii-bidiuk requested review from tuliren, alexandr-shegeda, alexandertsukanov and andriikorotkov December 13, 2021 14:17

github-actions bot added the area/connectors Connector related issues label Dec 13, 2021

This was linked to issues Dec 13, 2021

Bigquery destination SCD table does not work with array type from source Postgres table #4357

Closed

Json -> Avro / Parquet schema convert should support array field without items #7939

Closed

yurii-bidiuk mentioned this pull request Dec 13, 2021

🐛 Source Postgres: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8657

Closed

40 tasks

tuliren reviewed Dec 13, 2021

View reviewed changes

...-s3/src/main/java/io/airbyte/integrations/destination/s3/avro/JsonToAvroSchemaConverter.java Outdated Show resolved Hide resolved

tuliren reviewed Dec 13, 2021

View reviewed changes

...-s3/src/main/java/io/airbyte/integrations/destination/s3/avro/JsonToAvroSchemaConverter.java Outdated Show resolved Hide resolved

tuliren reviewed Dec 13, 2021

View reviewed changes

fixed PR comments, added test cases

b0627cb

yurii-bidiuk temporarily deployed to more-secrets December 13, 2021 22:22 Inactive

tuliren reviewed Dec 13, 2021

View reviewed changes

...tination-s3/src/test/resources/parquet/json_schema_converter/json_conversion_test_cases.json Outdated Show resolved Hide resolved

...tination-s3/src/test/resources/parquet/json_schema_converter/json_conversion_test_cases.json Outdated Show resolved Hide resolved

added more elements for test case

543c748

yurii-bidiuk temporarily deployed to more-secrets December 13, 2021 22:52 Inactive

tuliren mentioned this pull request Dec 14, 2021

Support enforcing fields to string according to schema airbytehq/json-avro-converter#10

Merged

Fix test case

324a0dd

tuliren approved these changes Dec 15, 2021

View reviewed changes

tuliren temporarily deployed to more-secrets December 15, 2021 00:55 Inactive

add array test case for JdbcSourceOperations

e28f4a5

yurii-bidiuk temporarily deployed to more-secrets December 15, 2021 21:03 Inactive

alexandr-shegeda marked this pull request as ready for review December 16, 2021 09:35

alexandr-shegeda approved these changes Dec 16, 2021

View reviewed changes

yurii-bidiuk merged commit 896910c into liren/postgres-types-v2 Dec 16, 2021

yurii-bidiuk deleted the bidiuk/db-sources-array branch December 16, 2021 09:45

This was referenced Dec 20, 2021

Bigquery destination SCD table does not work with array type from source Postgres table #4357

Closed

Json -> Avro / Parquet schema convert should support array field without items #7939

Closed

yurii-bidiuk added a commit that referenced this pull request Dec 20, 2021

bump version for affected sources from #8749

63c5d15

yurii-bidiuk mentioned this pull request Dec 20, 2021

bump version for affected sources from #8749 #8958

Merged

40 tasks

yurii-bidiuk added a commit that referenced this pull request Dec 22, 2021

bump version for affected sources from #8749

306f016

yurii-bidiuk added a commit that referenced this pull request Dec 23, 2021

bump version for affected sources from #8749

96993cf

yurii-bidiuk added a commit that referenced this pull request Dec 24, 2021

bump version for affected sources from #8749 (#8958)

cd30cf4

* bump versions * fix tests for cockroachdb * update changelog

jrhizor mentioned this pull request Dec 27, 2021

Bump Airbyte version from 0.35.1-alpha to 0.35.2-alpha #9119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8749

🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8749

yurii-bidiuk commented Dec 13, 2021 •

edited

Loading

tuliren left a comment

tuliren left a comment

tuliren commented Dec 14, 2021

tuliren commented Dec 14, 2021 •

edited

Loading

tuliren commented Dec 15, 2021 •

edited

Loading

alexandr-shegeda left a comment

tuliren commented Dec 20, 2021

yurii-bidiuk commented Dec 20, 2021

🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8749

🐛 Jdbc sources: switch from "string" to "array" schema type for columns with JDBCType.ARRAY #8749

Conversation

yurii-bidiuk commented Dec 13, 2021 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

tuliren left a comment

Choose a reason for hiding this comment

tuliren left a comment

Choose a reason for hiding this comment

tuliren commented Dec 14, 2021

tuliren commented Dec 14, 2021 • edited Loading

tuliren commented Dec 15, 2021 • edited Loading

alexandr-shegeda left a comment

Choose a reason for hiding this comment

tuliren commented Dec 20, 2021

yurii-bidiuk commented Dec 20, 2021

yurii-bidiuk commented Dec 13, 2021 •

edited

Loading

tuliren commented Dec 14, 2021 •

edited

Loading

tuliren commented Dec 15, 2021 •

edited

Loading