Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump version for affected sources from #8749 #8958

Merged
merged 3 commits into from
Dec 24, 2021
Merged

bump version for affected sources from #8749 #8958

merged 3 commits into from
Dec 24, 2021

Conversation

yurii-bidiuk
Copy link
Contributor

What

update versions for sources that were impacted by #8749

How

Updated version of JDBC sources

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

There is no user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 20, 2021
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1601746068
❌ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1601746068
🐛 https://gradle.com/s/6hthtvn6wleay

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601746651
❌ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601746651
🐛 https://gradle.com/s/yureifvt74oxa

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1601751914
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1601751914
🐛 https://gradle.com/s/do57esr66lrpa

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-redshift

🕑 connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1601752375
❌ connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1601752375
🐛

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:17 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1601753669
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1601753669
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:17 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601756382
❌ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601756382
🐛 https://gradle.com/s/5amu6cghknbag

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1601757840
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1601757840
🐛 https://gradle.com/s/nj5ylyush6ohy

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601758616
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601758616
🐛 https://gradle.com/s/22mcw6wplenm4

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:19 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:19 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-jdbc

🕑 connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/1601760549
❌ connectors/source-jdbc https://github.com/airbytehq/airbyte/actions/runs/1601760549
🐛 https://gradle.com/s/adezesyozlyie

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:19 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1601761782
❌ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1601761782
🐛 https://gradle.com/s/lf5u55xbgpleo

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601762665
❌ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601762665
🐛 https://gradle.com/s/bhs5wds7var3k

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:20 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:20 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1601765139
❌ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1601765139
🐛 https://gradle.com/s/atjjimbqmocrm

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-clickhouse-strict-encrypt

🕑 connectors/source-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601766379
❌ connectors/source-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1601766379
🐛 https://gradle.com/s/nvtwio3vnsw26

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:20 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 11:22 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 20, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1601921420
❌ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1601921420
🐛 https://gradle.com/s/lgncsmhpqqybk

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 24, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-cockroachdb

🕑 connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1618430371
✅ connectors/source-cockroachdb https://github.com/airbytehq/airbyte/actions/runs/1618430371

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 24, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1618430991
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1618430991

@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 24, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1618431498
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1618431498

@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:20 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 24, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1618432025
✅ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1618432025

@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:21 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 24, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1618434378
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1618434378

@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:23 Inactive
@yurii-bidiuk
Copy link
Contributor Author

yurii-bidiuk commented Dec 24, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-redshift

🕑 connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1618440415
✅ connectors/source-redshift https://github.com/airbytehq/airbyte/actions/runs/1618440415

@jrhizor jrhizor temporarily deployed to more-secrets December 24, 2021 07:26 Inactive
alexandr-shegeda
alexandr-shegeda approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. discussed with @yurii-bidiuk that connectors with failed tests will be fixed in a separate PR

@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review December 24, 2021 08:59
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 24, 2021
@yurii-bidiuk yurii-bidiuk temporarily deployed to more-secrets December 24, 2021 11:51 Inactive
@yurii-bidiuk yurii-bidiuk merged commit cd30cf4 into master Dec 24, 2021
@yurii-bidiuk yurii-bidiuk deleted the bidiuk/8749-bump-versions branch December 24, 2021 12:41
@jrhizor jrhizor mentioned this pull request Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/cockroachdb-strict-encrypt connectors/source/db2-strict-encrypt connectors/source/db2 connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yurii-bidiuk @tuliren @alexandr-shegeda @jrhizor @karinakuz