Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies Comp. #123

Closed
wants to merge 1 commit into from
Closed

Update Dependencies Comp. #123

wants to merge 1 commit into from

Conversation

Trackhe
Copy link

@Trackhe Trackhe commented Sep 6, 2020

For remove tsutils@3.17.1 requires a peer of typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta but none is installed. You must install peer dependencies yourself. Because typescript 4 was released.

@antonsamper
Copy link

Is CircleCI stuck?

@@ -50,7 +50,7 @@
"typescript": "^3.6.0-dev.20190804"
},
"peerDependencies": {
"typescript": ">=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta"
"typescript": ">=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta || >= 4.0.2 "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 4.0.2 instead of 4.0.0?

Copy link

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've inserted a trailing space

@AlexGodard
Copy link

Can we get this merged? This is blocking my image build that uses react-scripts (which in turn uses @typescript-eslint/eslint-plugin, which uses tsutils.)

Found: typescript@4.1.3
node_modules/typescript
  dev typescript@"^4.1.3" from the root project
  peer typescript@">=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta" from tsutils@3.17.1
  node_modules/tsutils
    tsutils@"^3.17.1" from @typescript-eslint/eslint-plugin@4.11.1
    node_modules/@typescript-eslint/eslint-plugin
      dev @typescript-eslint/eslint-plugin@"^4.11.1" from the root project
      2 more (react-scripts, eslint-config-react-app)
    tsutils@"^3.17.1" from @typescript-eslint/typescript-estree@4.11.1
    node_modules/@typescript-eslint/typescript-estree
      @typescript-eslint/typescript-estree@"4.11.1" from @typescript-eslint/parser@4.11.1
      node_modules/@typescript-eslint/parser
        dev @typescript-eslint/parser@"^4.11.1" from the root project
        3 more (@typescript-eslint/eslint-plugin, react-scripts, eslint-config-react-app)
      1 more (@typescript-eslint/experimental-utils)

Could not resolve dependency:
peerOptional typescript@"^3.2.1" from react-scripts@4.0.1
node_modules/react-scripts
  react-scripts@"^4.0.1" from the root project

@@ -50,7 +50,7 @@
"typescript": "^3.6.0-dev.20190804"
},
"peerDependencies": {
"typescript": ">=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta"
"typescript": ">=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta || >= 4.0.2 "
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this even necessary? >=2.8.0 includes 4.x as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know but without the change it was not working for me.

@ajafff
Copy link
Owner

ajafff commented Apr 23, 2021

see #134 (comment)

@ajafff ajafff closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants