Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the ESLint dev dependencies #9391

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 21, 2020

References

#9297

Attempt to address the first item in #9297 (comment)

However it looks like the latest tsutils hasn't been update yet:

$ jlpm why tsutils
yarn why v1.21.1
[1/4] Why do we have the module "tsutils"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "tsutils@3.17.1"
info Reasons this module exists
   - "_project_#@typescript-eslint#eslint-plugin" depends on it
   - Hoisted from "_project_#@typescript-eslint#eslint-plugin#tsutils"
   - Hoisted from "_project_#@typescript-eslint#parser#@typescript-eslint#typescript-estree#tsutils"
info Disk size without dependencies: "408KB"
info Disk size with unique dependencies: "464KB"
info Disk size with transitive dependencies: "464KB"
info Number of shared dependencies: 1
Done in 1.46s.

Code changes

Dev dependencies update.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio jtpio marked this pull request as draft November 21, 2020 12:02
@jtpio
Copy link
Member Author

jtpio commented Nov 21, 2020

@jtpio
Copy link
Member Author

jtpio commented Nov 21, 2020

f6ec55d marks these 2 rules as warnings. So they could be tackled separately for example in #9392

@jtpio jtpio marked this pull request as ready for review November 21, 2020 13:01
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 3.0 milestone Nov 30, 2020
@blink1073 blink1073 merged commit 2ac4579 into jupyterlab:master Nov 30, 2020
@jtpio jtpio deleted the bump-eslint-dev-deps branch November 30, 2020 17:23
@jtpio jtpio mentioned this pull request Nov 30, 2020
1 task
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:translation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants