New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate dts generator for ace-code and ace-builds #5427

Merged

nightwing merged 41 commits into ajaxorg:master from mkslanc:dts-generator

Nov 23, 2024

Contributor

mkslanc commented Dec 15, 2023 •

edited

Loading

Issue #, if available: #4640

Description of changes:
This pull request introduces changes that enable the generation of a comprehensive TypeScript declaration file, designed to be utilized as a public API. These modifications ensure that the generated declaration file accurately reflects the structure of both ace-builds and ace-code packages, providing a seamless integration for developers.

Key Features:

Unified Declaration: Consolidates type definitions across ace-builds and ace-code, facilitating easier maintenance and usage.
Project Structure Compliance: Adheres to the respective project structures, ensuring that the generated file is both accurate and functional.
All internal statements (started with $ or marked as private or @internal in jsDoc comment) would be filtered from final declaration

Disclaimer: For ace-builds, all internal module paths are modified to follow the ace-builds-internal/module structure, which could be used as completion items in IDE's.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

nightwing force-pushed the dts-generator branch from c916fc0 to d9928cf Compare

April 8, 2024 14:19

github-actions bot commented Apr 8, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc and others added 8 commits

April 8, 2024 18:21


          Update type definitions in various files and add a declaration generator

0b1d155


          Update TypeScript configuration for ACE declaration generator

a36f222


          correct types

362f238


          exclude src/mode (whole dit with files); correct final declaration fo…

a911b4c

…r ace-builds


          move for static method under Autocomplete class; fix types

a57489b


          remove private properties/methods from public API

0e4c470


          remove unnecessary generated declaration; fix tsconfig.json

ee14196


          update ace.d.ts

nightwing force-pushed the dts-generator branch from d9928cf to 3674429 Compare

April 8, 2024 14:21

github-actions bot commented Apr 8, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc added 2 commits

April 17, 2024 15:12


          split modules by different context

65d23ff


          separate libs from core modules

260acaa

github-actions bot commented Apr 17, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          filter all nodes with private modifier

a6df107

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

1 similar comment

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

nightwing force-pushed the dts-generator branch from 3f9e279 to ec775a3 Compare

April 18, 2024 13:15

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          update ci script

b3db1c3

nightwing force-pushed the dts-generator branch from ec775a3 to b3db1c3 Compare

April 18, 2024 13:16

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          set default d.ts format code settings

ed40c51

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc added 2 commits

April 18, 2024 18:45


          Merge branch 'refs/heads/master' into dts-generator

48cac72


          re-generate after new changes

7e8d9bf

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          add missing type

da46e1f

github-actions bot commented Apr 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          add new events; improve EventEmitter method declarations; fix Config …

0ede0d8

…type

github-actions bot commented Sep 30, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          add a test

d862604

github-actions bot commented Sep 30, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          improve types

6aca79a

github-actions bot commented Oct 11, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc mentioned this pull request

Improve types for internal development #5662

Merged

1 task

mkslanc added 2 commits

November 6, 2024 17:13


          Merge remote-tracking branch 'ace/master' into dts-generator

260aed8

# Conflicts:
#	ace-internal.d.ts
#	ace.d.ts
#	src/editor.js
#	src/mode/behaviour/liquid.js
#	src/mode/behaviour/xquery.js
#	src/mode/text.js
#	src/search.js


          update to new version

fa6993c

github-actions bot commented Nov 7, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          fix the new test

17c3e18

github-actions bot commented Nov 13, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc added 2 commits

November 13, 2024 13:06


          further types improving

9f1a005


          update types; improve generation by removing undefined declarations

fd90e44

github-actions bot commented Nov 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc added 2 commits

November 18, 2024 15:13


          Merge branch 'master' into dts-generator

d4be802

# Conflicts:
#	ace.d.ts


          update to last version

b2f0316

github-actions bot commented Nov 18, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          remove duplicating types comments; move types to types directory

44f7f07

github-actions bot commented Nov 19, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          corrects import statements

2583e1c

github-actions bot commented Nov 19, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          fix: create type dir, if it doesn't exist

6f05004

github-actions bot commented Nov 19, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          add auto generated header to type declarations

b0f9f2c

github-actions bot commented Nov 20, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.


          Merge branch 'master' into dts-generator

a2122ec

# Conflicts:
#	ace.d.ts

github-actions bot commented Nov 23, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

nightwing merged commit 690052d into ajaxorg:master

4 checks passed

mkslanc mentioned this pull request

Better separate type declarations #5695

Open

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet