Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types for internal development #5662

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Oct 23, 2024

Issue #, if available:

Description of changes:
Picked type changes from #5427 ; should improve developers experience, while #5427 in review stage.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (b168a97) to head (b5a2f5e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/autocomplete.js 76.92% 3 Missing ⚠️
src/bidihandler.js 33.33% 2 Missing ⚠️
src/virtual_renderer.js 77.77% 2 Missing ⚠️
src/editor.js 50.00% 1 Missing ⚠️
src/mode/text.js 75.00% 1 Missing ⚠️
src/snippets.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5662    +/-   ##
========================================
  Coverage   87.00%   87.01%            
========================================
  Files         594      598     +4     
  Lines       43516    43666   +150     
  Branches     7174     7205    +31     
========================================
+ Hits        37862    37995   +133     
- Misses       5654     5671    +17     
Flag Coverage Δ
unittests 87.01% <77.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 25d3fee into ajaxorg:master Oct 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants