Keybind edit, show notice again, ignore rate limits #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…experimental-ajay
This reverts commit 047432a.
…experimental-ajay
…nsorBlock into experimental-ajay
Closed
Mathnerd314
reviewed
Nov 7, 2019
| var dontShowNotice = false; | ||
| chrome.storage.sync.get(["dontShowNoticeAgain"], function(result) { | ||
| chrome.storage.sync.get(["dontShowNotice"], function(result) { | ||
| let dontShowNoticeAgain = result.dontShowNoticeAgain; |
There was a problem hiding this comment.
This is wrong. Storage returns {dontShowNotice: true} so result.dontShowNoticeAgain is undefined and it shows the notice every time.
There was a problem hiding this comment.
Oops, I fixed this in popup.js but forgot here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.