Submit Hotkey #33
Submit Hotkey #33
Conversation
|
After looking at it again, I can see how it can work, but I don't really like doing it this way, I feel it's easier to make mistakes. I think it's best to find all the sponsors in the video, THEN submit. This makes it so the user is sure those are the correct sponsors. If you do want it this way for yourself, you can make it an option, but I don't want that to be the default. |
|
Submitting one at a time has the benefit of being able to cancel per sponsor |
|
That could be resolved with a UI change. And sadly, you can't just use a variable created there because it has to sync up with the popup. I recommend checking if the document.getElementById("submitButton").style != "none". I'll merge it in in if you make it an option and not on by default. |
|
I dont like the global popup as its not per video |
| Settings.hotkeys = {}; // TEMP | ||
| Settings.onekey = false; // TEMP | ||
| Settings.hotkeys.submit = "Quote"; // TEMP | ||
| Settings.hotkeys.start = "Semicolon"; // TEMP |
There was a problem hiding this comment.
Can you set this up so the settings save? Right now it does nothing as it is by default just the same
There was a problem hiding this comment.
I would but theirs no place to change them or to store the default values
There was a problem hiding this comment.
Yea, for now you can put it in the options section of the popup
There was a problem hiding this comment.
There is no option page currently???
There was a problem hiding this comment.
Yes there is, click the options button the popup
There was a problem hiding this comment.
Waiting for the UI changes
No description provided.