Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish Rust 1.60 (or similar) as Minimum Supported Rust Version #157

Closed
ajrcarey opened this issue Aug 25, 2024 · 3 comments
Closed

Establish Rust 1.60 (or similar) as Minimum Supported Rust Version #157

ajrcarey opened this issue Aug 25, 2024 · 3 comments
Assignees

Comments

@ajrcarey
Copy link
Owner

Follow-on from #137. Establish a formal MSRV for pdfium-render, aiming ideally for Rust 1.60, to be published in crate release 0.8.25.

@ajrcarey ajrcarey self-assigned this Aug 25, 2024
@ajrcarey
Copy link
Owner Author

1.60 is the earliest version in which Cargo supports the dep:name style of optional dependency instantiation in crate features. If not for reliance on this in Cargo.toml, we could potentially aim for 1.59.

@ajrcarey
Copy link
Owner Author

Output from cargo-msrv states that, with current dependency tree, MSRV is 1.80. We'll need to downgrade some dependencies in order to hit 1.60.

The image crate appears particularly problematic (perhaps not surprisingly); it brings in a lot of recent dependencies which require relatively recent rust versions. Omitting the image crate feature shows MSRV 1.60 would be possible if the upper bound on the chrono dependency was changed; currently, chrono 0.4.38 requires Rust 1.61.

With image feature disabled, cargo-msrv confirms an MSRV of 1.61.

@ajrcarey
Copy link
Owner Author

Omitting image feature and limiting chrono dependency to 0.4.31 meets MSRV target of 1.60. Updated README. Included in release 0.8.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant