Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax chrono dependency version based on consumer feedback. #166

Closed
ajrcarey opened this issue Nov 3, 2024 · 5 comments
Closed

Relax chrono dependency version based on consumer feedback. #166

ajrcarey opened this issue Nov 3, 2024 · 5 comments
Assignees

Comments

@ajrcarey
Copy link
Owner

ajrcarey commented Nov 3, 2024

Follow-on from #157, #163. Relax the chrono dependency from its current chrono = "0.4, <= 0.4.31" to simply chrono = "0.4" to allow it to float. This will necessarily relax the MSRV of this crate from 1.60 to 1.63 or similar. The aim is to mitigate version conflicts that have been experienced by several consumers since establishing an MSRV of 1.60.

@ajrcarey ajrcarey self-assigned this Nov 3, 2024
@ajrcarey
Copy link
Owner Author

ajrcarey commented Nov 3, 2024

Of course, there is another option: remove the chrono dependency entirely. I believe it's only used in the utils::dates module.

@ajrcarey
Copy link
Owner Author

ajrcarey commented Nov 3, 2024

cargo msrv reports that letting the chrono dependency float results in an MSRV of 1.61.

@ajrcarey
Copy link
Owner Author

ajrcarey commented Nov 3, 2024

(compared to an MSRV of 1.79 when feature image_025 is enabled)

@ajrcarey
Copy link
Owner Author

ajrcarey commented Nov 3, 2024

Updated self-reported MSRV in Cargo.toml. Updated README.

ajrcarey pushed a commit that referenced this issue Nov 3, 2024
@ajrcarey
Copy link
Owner Author

ajrcarey commented Nov 9, 2024

Released as part of crate version 0.8.26.

@ajrcarey ajrcarey closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant