chore: SDK implementation of SpiEventSourcedEntity #39
Conversation
patriknw
commented
Nov 26, 2024
patriknw
commented
- first stab, untested
- corresponds to EventSourcedEntitiesImpl, ReflectiveEventSourcedEntityRouter, EventSourcedEntityRouter
* first stab, untested * corresponds to EventSourcedEntitiesImpl, ReflectiveEventSourcedEntityRouter, EventSourcedEntityRouter
| new CommandContextImpl(entityId, 0L, "", 0, false, MetadataImpl.of(Nil), None, tracerFactory) | ||
| val context = new EventSourcedEntityContextImpl(entityId) | ||
| val router = createRouter(context) | ||
| router.entity._internalSetCommandContext(Optional.of(cmdContext)) |
There was a problem hiding this comment.
We don't need the command context when accessing emptyState
There was a problem hiding this comment.
Thanks, that will make this more clean and I can remove the entityId parameter again.
There was a problem hiding this comment.
Not yet, you need it for the EventSourcedEntityContextImpl.
But I have been playing with the same for workflows now and I believe the id must be passed earlier and be a field on the SPI impl.
So the descriptor would be something like.
new EventSourcedEntityDescriptor(componentId, id => entitySpi(id))
There was a problem hiding this comment.
maybe we should call it a SpiFactory since not really a descriptor anymore.
| ScalaPbAny.fromJavaProto(messageCodec.encodeJava(obj)) | ||
|
|
||
| override def fromProto(pb: ScalaPbAny): Deserialized = | ||
| messageCodec.decodeMessage(pb).asInstanceOf[Deserialized] |
There was a problem hiding this comment.
This is not correct.
decodeMessage just return the passed PbAny.
override def decodeMessage(value: ScalaPbAny): Any = {
value
}
Instead, we should use
def decodeMessage[T](expectedType: Class[T], bytes: akka.util.ByteString): T
And fromProto should be
fromProto[T](expectedType: Class[T], pb: ScalaPbAny): T
| // FIXME smuggling 0 arity method called from component client through here | ||
| ScalaPbAny.defaultInstance.withTypeUrl(AnySupport.JsonTypeUrlPrefix).withValue(ByteString.empty()))) | ||
| val metadata: Metadata = | ||
| MetadataImpl.of(Nil) // FIXME MetadataImpl.of(command.metadata.map(_.entries.toVector).getOrElse(Nil)) |
There was a problem hiding this comment.
There is MetadataImpl.Empty for this, but doesn't matter much for now.
| def replyOrError(updatedState: SpiEventSourcedEntity.State): (Option[ScalaPbAny], Option[SpiEntity.Error]) = { | ||
| commandEffect.secondaryEffect(updatedState) match { | ||
| case ErrorReplyImpl(description, status) => | ||
| val errorCode = status.map(_.value).getOrElse(Status.Code.UNKNOWN.value) |
There was a problem hiding this comment.
This is legacy.
The Effect API doesn't allow the usage of an error code anymore, but the protocol is still requiring it.
I'm sure that this will always be a None and now falling back to Status.Code.UNKNOWN.
We should remove this completely.
There was a problem hiding this comment.
I'll have to test these error scenarios, because something wasn't working without the error code
|
Continued in #45 |
