chore: using spi for TimedAction and ESE #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* first stab, untested * corresponds to EventSourcedEntitiesImpl, ReflectiveEventSourcedEntityRouter, EventSourcedEntityRouter
patriknw
approved these changes
Dec 2, 2024
| @@ -375,7 +421,8 @@ private final class Sdk( | |||
| } | |||
|
|
|||
| val actionAndConsumerServices = services.filter { case (_, service) => | |||
| service.getClass == classOf[TimedActionService[_]] || service.getClass == classOf[ConsumerService[_]] | |||
| /*service.getClass == classOf[TimedActionService[_]] ||*/ | |||
| componentClass: Class[_], | ||
| messageCodec: JsonMessageCodec, | ||
| factory: EventSourcedEntityContext => ES, | ||
| snapshotEvery: Int) |
There was a problem hiding this comment.
This isn't used here, passed to runtime via settings instead. I'll follow up in separate PR.
|
|
||
| override def emptyState: SpiEventSourcedEntity.State = { | ||
| // FIXME rather messy with the contexts here | ||
| val context = new EventSourcedEntityContextImpl("FIXME_ID") |
There was a problem hiding this comment.
I'll follow up, related to the factory that Renato has proposed.
| ScalaPbAny.fromJavaProto(messageCodec.encodeJava(obj)) | ||
|
|
||
| override def fromProto(pb: ScalaPbAny): Deserialized = | ||
| messageCodec.decodeMessage(pb).asInstanceOf[Deserialized] |
There was a problem hiding this comment.
this is incorrect, I'll follow up, see #39 (comment)
samples/shopping-cart-quickstart/src/main/resources/include-dev-loggers.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on: #39
locally all test are green