v1.4.0-beta1 Release #97
Conversation
* added proper IActorRef serialization for MongoDb binary format * added all Akka.Persistence.TCK.Serialization specs * added v1.4.0 release notes * close #72
* upgrade to Akka.NET v1.4.0-beta* * added Unix-style line endings back for build.sh
Bumps MongoDB.Driver from 2.7.0 to 2.9.1. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* migrating to .NET Core 3.0 tests and build system * Unix line endings
| { | ||
| Type type = null; | ||
|
|
||
| if (string.IsNullOrEmpty(entry.Manifest)) |
There was a problem hiding this comment.
@Aaronontheweb shouldn't this be IF NOT?
There was a problem hiding this comment.
yes, I think you're right
|
|
||
| if (string.IsNullOrEmpty(entry.Manifest)) | ||
| type = Type.GetType(entry.Manifest, throwOnError: true); | ||
|
|
There was a problem hiding this comment.
Also, an ELSE seems to be missing to retrieve the SerializerId. Otherwise we could wind up with no Type, SerializerId, and Manifest.
There was a problem hiding this comment.
Let me take a look at what we did for the journal - most of the serialization, going forward, is handled internally by the PersistenceSnapshotSerializer: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Persistence/Serialization/PersistenceSnapshotSerializer.cs
There was a problem hiding this comment.
Yeah, the code I did for the journal - which was heavily backwards compatibility tested, is clean. The snapshot store's is not. I'll submit another PR and push a new beta.
| { | ||
| Type type = null; | ||
|
|
||
| if (string.IsNullOrEmpty(entry.Manifest)) |
There was a problem hiding this comment.
yes, I think you're right
|
|
||
| if (string.IsNullOrEmpty(entry.Manifest)) | ||
| type = Type.GetType(entry.Manifest, throwOnError: true); | ||
|
|
There was a problem hiding this comment.
Let me take a look at what we did for the journal - most of the serialization, going forward, is handled internally by the PersistenceSnapshotSerializer: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Persistence/Serialization/PersistenceSnapshotSerializer.cs
|
|
||
| if (string.IsNullOrEmpty(entry.Manifest)) | ||
| type = Type.GetType(entry.Manifest, throwOnError: true); | ||
|
|
There was a problem hiding this comment.
Yeah, the code I did for the journal - which was heavily backwards compatibility tested, is clean. The snapshot store's is not. I'll submit another PR and push a new beta.
1.4.0-beta1 October 30 2019
Beta release of Akka.Persistence.MongoDB which implements the new standardized Akka.Persistence serialization paradigm going forward. Has full backwards compatibility for reading events which were written in 1.3.[0-14] style serialization.