obsolete AddOrSet (#7408)

* obsolete AddOrSet * added API approvals --------- Co-authored-by: Aaron Stannard <aaron@petabridge.com> Co-authored-by: Gregorius Soedharmo <arkatufus@yahoo.com>
akkadotnet · Jan 13, 2025 · 39cce0a · 39cce0a
1 parent f362af5
commit 39cce0a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
@@ -5642,6 +5642,7 @@ namespace Akka.Util.Internal
     public class static Extensions
     {
         public static System.Collections.Generic.IDictionary<TKey, TValue> AddAndReturn<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> hash, TKey key, TValue value) { }
+        [System.ObsoleteAttribute("Use the dictionary setter directly")]
         public static void AddOrSet<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> hash, TKey key, TValue value) { }
         public static T AsInstanceOf<T>(this object self) { }
         public static string BetweenDoubleQuotes(this string self) { }

diff --git a/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt b/src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
@@ -5631,6 +5631,7 @@ namespace Akka.Util.Internal
     public class static Extensions
     {
         public static System.Collections.Generic.IDictionary<TKey, TValue> AddAndReturn<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> hash, TKey key, TValue value) { }
+        [System.ObsoleteAttribute("Use the dictionary setter directly")]
         public static void AddOrSet<TKey, TValue>(this System.Collections.Generic.IDictionary<TKey, TValue> hash, TKey key, TValue value) { }
         public static T AsInstanceOf<T>(this object self) { }
         public static string BetweenDoubleQuotes(this string self) { }

diff --git a/src/core/Akka/Util/Internal/Extensions.cs b/src/core/Akka/Util/Internal/Extensions.cs
@@ -111,12 +111,10 @@ public static string BetweenDoubleQuotes(this string self)
         /// <param name="hash">TBD</param>
         /// <param name="key">TBD</param>
         /// <param name="value">TBD</param>
+        [Obsolete("Use the dictionary setter directly")]
         public static void AddOrSet<TKey, TValue>(this IDictionary<TKey, TValue> hash, TKey key, TValue value)
         {
-            if (hash.ContainsKey(key))
-                hash[key] = value;
-            else
-                hash.Add(key,value);
+            hash[key] = value;
         }
 
         /// <summary>
@@ -146,7 +144,7 @@ public static TValue GetOrElse<TKey, TValue>(this IDictionary<TKey, TValue> hash
         /// <returns>TBD</returns>
         public static IDictionary<TKey, TValue> AddAndReturn<TKey, TValue>(this IDictionary<TKey, TValue> hash, TKey key, TValue value)
         {
-            hash.AddOrSet(key, value);
+            hash[key] = value;
             return hash;
         }