Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obsolete AddOrSet #7408

Merged
merged 4 commits into from
Jan 13, 2025
Merged

obsolete AddOrSet #7408

merged 4 commits into from
Jan 13, 2025
+5 −5

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Dec 16, 2024 •
edited
Loading

ContainsKey in AddOrSet is redundant. so may as well just set directly and burn the extension

note this will also perform better

@Aaronontheweb Aaronontheweb mentioned this pull request Jan 13, 2025
Open
@Aaronontheweb
Copy link
Member

Added an issue to remove this from the API altogether in v1.6 #7463

@Aaronontheweb Aaronontheweb added this to the 1.5.35 milestone Jan 13, 2025
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) January 13, 2025 17:17
@Aaronontheweb Aaronontheweb merged commit 39cce0a into akkadotnet:dev Jan 13, 2025
9 of 12 checks passed
@Arkatufus Arkatufus mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api-change
Projects
None yet
Milestone
1.5.35
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @Aaronontheweb @Arkatufus