Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Akka.Util.Resolver #4857

Closed
Aaronontheweb opened this issue Mar 17, 2021 · 1 comment · Fixed by #6425
Closed

Delete Akka.Util.Resolver #4857

Aaronontheweb opened this issue Mar 17, 2021 · 1 comment · Fixed by #6425
Labels
akka-actor api-change good for first-time contributors
Milestone
1.5.0

Comments

@Aaronontheweb
Copy link
Member

This class is only used for unit testing and we would be better off without it in the public API:

https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka/Util/Resolver.cs

Send this pull request to the feature/artery branch.
@Aaronontheweb Aaronontheweb added this to the 1.5.0 milestone Mar 17, 2021
@Aaronontheweb
Copy link
Member Author

Any unit tests that depend on this will be cleaned up as part of #3599

erifol pushed a commit to erifol/akka.net that referenced this issue Mar 20, 2021
@erikmafo
close akkadotnet#4857 - delete resolver
89d3035
@Aaronontheweb Aaronontheweb moved this from Todo to Spec Approved in Akka.NET v1.5 Total Delivery Aug 9, 2022
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this issue Feb 21, 2023
@Aaronontheweb
delete Akka.Util.,Resolver
eb55ec9 
* close akkadotnet#4857
* moved `Base64Encoding` out of the public API since its name can easily clash
@Aaronontheweb Aaronontheweb mentioned this issue Feb 21, 2023
Merged
5 tasks
Aaronontheweb added a commit that referenced this issue Feb 21, 2023
@Aaronontheweb
delete Akka.Util.,Resolver (#6425)
9779a37 
* close #4857
* moved `Base64Encoding` out of the public API since its name can easily clash
@github-project-automation github-project-automation bot moved this from Spec Approved to Done in Akka.NET v1.5 Total Delivery Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
akka-actor api-change good for first-time contributors
Projects
No open projects
Akka.NET v1.5 Total Delivery
Status: Done
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

delete Akka.Util.Resolver Aaronontheweb/akka.net
1 participant
@Aaronontheweb