delete Akka.Util.Resolver
#6425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* close akkadotnet#4857 * moved `Base64Encoding` out of the public API since its name can easily clash
Aaronontheweb
commented
Feb 21, 2023
| /// </summary> | ||
| public static class Base64Encoding | ||
| internal static class Base64Encoding |
There was a problem hiding this comment.
Marked as internal - no need to expose this to other users.
Aaronontheweb
commented
Feb 21, 2023
| @@ -14,16 +14,13 @@ | |||
| using Akka.Remote.Transport; | |||
| using Akka.Routing; | |||
| using Akka.TestKit; | |||
| using Akka.TestKit.TestEvent; | |||
| using Akka.Util; | |||
There was a problem hiding this comment.
Formatted this file and deleted the only remaining Resolver usages here - tests still passed without it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Base64Encodingout of the public API since its name can easily clashChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):