[WARNING] CS0628: `new protected member declared in sealed type` #6626

eaba · 2023-03-28T12:03:55Z

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

This change follows the Akka.NET API Compatibility Guidelines.
This change follows the Akka.NET Wire Compatibility Guidelines.
I have reviewed my own pull request.

eaba · 2023-03-28T13:04:11Z

src/core/Akka.Remote/Endpoint.cs

@@ -361,7 +361,7 @@ public EndpointAssociationException(string message)
        /// </summary>
        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized object data about the exception being thrown.</param>
        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual information about the source or destination.</param>
-        protected EndpointAssociationException(SerializationInfo info, StreamingContext context)
+        EndpointAssociationException(SerializationInfo info, StreamingContext context)


I have removed that protected @Aaronontheweb

eaba · 2023-03-28T13:04:21Z

src/core/Akka.Remote/Endpoint.cs

@@ -386,7 +386,7 @@ public OversizedPayloadException(string message)
        /// </summary>
        /// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized object data about the exception being thrown.</param>
        /// <param name="context">The <see cref="StreamingContext"/> that contains contextual information about the source or destination.</param>
-        protected OversizedPayloadException(SerializationInfo info, StreamingContext context)
+        OversizedPayloadException(SerializationInfo info, StreamingContext context)


I have removed that protected @Aaronontheweb

eaba · 2023-03-28T13:04:32Z

src/core/Akka.Streams/ActorMaterializer.cs

@@ -347,7 +347,7 @@ public AbruptStageTerminationException(GraphStageLogic logic)
        /// </summary>
        /// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
        /// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected AbruptStageTerminationException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+        AbruptStageTerminationException(SerializationInfo info, StreamingContext context) : base(info, context) { }


I have removed that protected @Aaronontheweb

eaba · 2023-03-28T13:04:40Z

src/core/Akka.Streams/Dsl/Graph.cs

@@ -1219,7 +1219,7 @@ public PartitionOutOfBoundsException(string message) : base(message)
        /// </summary>
        /// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
        /// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected PartitionOutOfBoundsException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+        PartitionOutOfBoundsException(SerializationInfo info, StreamingContext context) : base(info, context) { }


I have removed that protected @Aaronontheweb

eaba · 2023-03-28T13:04:47Z

src/core/Akka.Streams/Dsl/Tcp.cs

@@ -309,7 +309,7 @@ public TcpIdleTimeoutException(string message, TimeSpan duration) : base(message
        /// </summary>
        /// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
        /// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected TcpIdleTimeoutException(SerializationInfo info, StreamingContext context) : base(info, context) { }
+        TcpIdleTimeoutException(SerializationInfo info, StreamingContext context) : base(info, context) { }


I have removed that protected @Aaronontheweb

eaba · 2023-03-28T13:04:58Z

src/core/Akka/Actor/Scheduler/SchedulerException.cs

@@ -26,7 +26,7 @@ public sealed class SchedulerException : AkkaException
        /// </summary>
        /// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
        /// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected SchedulerException(SerializationInfo info, StreamingContext context)
+        SchedulerException(SerializationInfo info, StreamingContext context)


I have removed that protected @Aaronontheweb

eaba · 2023-03-28T13:05:47Z

src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt

@@ -1804,7 +1803,6 @@ namespace Akka.Streams.Dsl
    public sealed class PartitionOutOfBoundsException : System.Exception
    {
        public PartitionOutOfBoundsException(string message) { }
-        protected PartitionOutOfBoundsException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }


removed @Aaronontheweb

eaba · 2023-03-28T13:05:56Z

src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt

@@ -12,7 +12,6 @@ namespace Akka.Streams
    public sealed class AbruptStageTerminationException : System.Exception
    {
        public AbruptStageTerminationException(Akka.Streams.Stage.GraphStageLogic logic) { }
-        protected AbruptStageTerminationException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }


removed @Aaronontheweb

eaba · 2023-03-28T13:06:05Z

src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt

@@ -1614,7 +1614,6 @@ namespace Akka.Actor
    public sealed class SchedulerException : Akka.Actor.AkkaException
    {
        public SchedulerException(string message) { }
-        protected SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }


removed @Aaronontheweb

I think that needs to be made public, probably

eaba

@Aaronontheweb changes

Aaronontheweb

Need the serialization constructors back, so make them public instead

Aaronontheweb · 2023-03-28T17:46:24Z

src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt

@@ -1614,7 +1614,6 @@ namespace Akka.Actor
    public sealed class SchedulerException : Akka.Actor.AkkaException
    {
        public SchedulerException(string message) { }
-        protected SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }


I think that needs to be made public, probably

Aaronontheweb · 2023-03-28T17:46:38Z

src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt

@@ -1612,7 +1612,6 @@ namespace Akka.Actor
    public sealed class SchedulerException : Akka.Actor.AkkaException
    {
        public SchedulerException(string message) { }
-        protected SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }


Make all of these public

eaba · 2023-03-29T01:09:07Z

Changes to public @Aaronontheweb

new protected member declared in sealed type

55f757a

eaba commented Mar 28, 2023

View reviewed changes

eaba marked this pull request as ready for review March 28, 2023 13:07

Aaronontheweb requested changes Mar 28, 2023

View reviewed changes

eaba added 2 commits March 29, 2023 02:06

changes to public

b4c68e1

Merge branch 'dev' into protected_sealed_type

2f27a55

Aaronontheweb approved these changes Mar 30, 2023

View reviewed changes

Aaronontheweb merged commit 9135b85 into akkadotnet:dev Mar 30, 2023

eaba deleted the protected_sealed_type branch March 30, 2023 17:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WARNING] CS0628: `new protected member declared in sealed type` #6626

[WARNING] CS0628: `new protected member declared in sealed type` #6626

eaba commented Mar 28, 2023 •

edited

Loading

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

eaba Mar 28, 2023

Aaronontheweb Mar 28, 2023

eaba left a comment

Aaronontheweb left a comment

Aaronontheweb Mar 28, 2023

Aaronontheweb Mar 28, 2023

eaba commented Mar 29, 2023

[WARNING] CS0628: new protected member declared in sealed type #6626

[WARNING] CS0628: new protected member declared in sealed type #6626

Conversation

eaba commented Mar 28, 2023 • edited Loading

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eaba left a comment

Choose a reason for hiding this comment

Aaronontheweb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eaba commented Mar 29, 2023

[WARNING] CS0628: `new protected member declared in sealed type` #6626

[WARNING] CS0628: `new protected member declared in sealed type` #6626

eaba commented Mar 28, 2023 •

edited

Loading