Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WARNING] CS0628: new protected member declared in sealed type #6626

Merged
merged 3 commits into from
Mar 30, 2023
Merged

[WARNING] CS0628: new protected member declared in sealed type #6626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55f757a
new protected member declared in sealed type
eaba Mar 28, 2023
b4c68e1
changes to `public`
eaba Mar 29, 2023
2f27a55
Merge branch 'dev' into protected_sealed_type
eaba Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,7 +1614,7 @@ namespace Akka.Actor
public sealed class SchedulerException : Akka.Actor.AkkaException
{
public SchedulerException(string message) { }
protected SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed @Aaronontheweb

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that needs to be made public, probably

public SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
}
public class static SchedulerExtensions
{
Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,7 +1612,7 @@ namespace Akka.Actor
public sealed class SchedulerException : Akka.Actor.AkkaException
{
public SchedulerException(string message) { }
protected SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make all of these public

public SchedulerException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
}
public class static SchedulerExtensions
{
Expand Down
6 changes: 3 additions & 3 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Akka.Streams
public sealed class AbruptStageTerminationException : System.Exception
{
public AbruptStageTerminationException(Akka.Streams.Stage.GraphStageLogic logic) { }
protected AbruptStageTerminationException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public AbruptStageTerminationException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
}
public class AbruptTerminationException : System.Exception
{
Expand Down Expand Up @@ -1804,7 +1804,7 @@ namespace Akka.Streams.Dsl
public sealed class PartitionOutOfBoundsException : System.Exception
{
public PartitionOutOfBoundsException(string message) { }
protected PartitionOutOfBoundsException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public PartitionOutOfBoundsException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
}
public class PartitionWith<TIn, TOut0, TOut1> : Akka.Streams.Stage.GraphStage<Akka.Streams.FanOutShape<TIn, TOut0, TOut1>>
{
Expand Down Expand Up @@ -2393,7 +2393,7 @@ namespace Akka.Streams.Dsl
public sealed class TcpIdleTimeoutException : System.TimeoutException
{
public TcpIdleTimeoutException(string message, System.TimeSpan duration) { }
protected TcpIdleTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public TcpIdleTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public System.TimeSpan Duration { get; }
}
public class static TcpStreamExtensions
Expand Down
6 changes: 3 additions & 3 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveStreams.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Akka.Streams
public sealed class AbruptStageTerminationException : System.Exception
{
public AbruptStageTerminationException(Akka.Streams.Stage.GraphStageLogic logic) { }
protected AbruptStageTerminationException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed @Aaronontheweb

public AbruptStageTerminationException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
}
public class AbruptTerminationException : System.Exception
{
Expand Down Expand Up @@ -1804,7 +1804,7 @@ namespace Akka.Streams.Dsl
public sealed class PartitionOutOfBoundsException : System.Exception
{
public PartitionOutOfBoundsException(string message) { }
protected PartitionOutOfBoundsException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed @Aaronontheweb

public PartitionOutOfBoundsException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
}
public class PartitionWith<TIn, TOut0, TOut1> : Akka.Streams.Stage.GraphStage<Akka.Streams.FanOutShape<TIn, TOut0, TOut1>>
{
Expand Down Expand Up @@ -2393,7 +2393,7 @@ namespace Akka.Streams.Dsl
public sealed class TcpIdleTimeoutException : System.TimeoutException
{
public TcpIdleTimeoutException(string message, System.TimeSpan duration) { }
protected TcpIdleTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public TcpIdleTimeoutException(System.Runtime.Serialization.SerializationInfo info, System.Runtime.Serialization.StreamingContext context) { }
public System.TimeSpan Duration { get; }
}
public class static TcpStreamExtensions
Expand Down
6 changes: 3 additions & 3 deletions src/core/Akka.Remote/Endpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ public EndpointDisassociatedException(string message)
/// </summary>
/// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext"/> that contains contextual information about the source or destination.</param>
protected EndpointDisassociatedException(SerializationInfo info, StreamingContext context)
public EndpointDisassociatedException(SerializationInfo info, StreamingContext context)
: base(info, context)
{
}
Expand Down Expand Up @@ -361,7 +361,7 @@ public EndpointAssociationException(string message, Exception innerException) :
/// </summary>
/// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext"/> that contains contextual information about the source or destination.</param>
protected EndpointAssociationException(SerializationInfo info, StreamingContext context)
EndpointAssociationException(SerializationInfo info, StreamingContext context)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed that protected @Aaronontheweb

: base(info, context)
{
}
Expand All @@ -386,7 +386,7 @@ public OversizedPayloadException(string message)
/// </summary>
/// <param name="info">The <see cref="SerializationInfo"/> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext"/> that contains contextual information about the source or destination.</param>
protected OversizedPayloadException(SerializationInfo info, StreamingContext context)
OversizedPayloadException(SerializationInfo info, StreamingContext context)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed that protected @Aaronontheweb

: base(info, context)
{
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka.Streams/ActorMaterializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ public AbruptStageTerminationException(GraphStageLogic logic)
/// </summary>
/// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
protected AbruptStageTerminationException(SerializationInfo info, StreamingContext context) : base(info, context) { }
public AbruptStageTerminationException(SerializationInfo info, StreamingContext context) : base(info, context) { }
}


Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka.Streams/Dsl/Graph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ public PartitionOutOfBoundsException(string message) : base(message)
/// </summary>
/// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
protected PartitionOutOfBoundsException(SerializationInfo info, StreamingContext context) : base(info, context) { }
public PartitionOutOfBoundsException(SerializationInfo info, StreamingContext context) : base(info, context) { }
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka.Streams/Dsl/Tcp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ public TcpIdleTimeoutException(string message, TimeSpan duration) : base(message
/// </summary>
/// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
protected TcpIdleTimeoutException(SerializationInfo info, StreamingContext context) : base(info, context) { }
public TcpIdleTimeoutException(SerializationInfo info, StreamingContext context) : base(info, context) { }

public TimeSpan Duration { get; }
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/Akka/Actor/Scheduler/SchedulerException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public SchedulerException(string message) : base(message) { }
/// </summary>
/// <param name="info">The <see cref="SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
/// <param name="context">The <see cref="StreamingContext" /> that contains contextual information about the source or destination.</param>
protected SchedulerException(SerializationInfo info, StreamingContext context)
public SchedulerException(SerializationInfo info, StreamingContext context)
: base(info, context)
{
}
Expand Down