-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devx): allow automated backporting of PRs #1936
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2f43805
to
c85f2d7
Compare
# xref: https://github.com/korthout/backport-action#inputs | ||
with: | ||
# Use token to allow workflows to be triggered for the created PR | ||
github_token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this GitHub secret is available to this repository, but I noticed it was used in some others within this GitHub organization.
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
c85f2d7
to
bb6a8e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1936 +/- ##
=======================================
Coverage 45.67% 45.67%
=======================================
Files 235 235
Lines 15825 15825
=======================================
Hits 7228 7228
Misses 8241 8241
Partials 356 356 ☔ View full report in Codecov by Sentry. |
# Use token to allow workflows to be triggered for the created PR | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
# Match labels with pattern `backport/<target-branch>` | ||
label_pattern: '^backport\/([^ ]+)$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Where does $target_branch
get set? I see a capture group in this regex, but I do not see where or how $target_branch
takes on that value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The capture group is automatically taken as the target branch, see: https://github.com/korthout/backport-action?tab=readme-ov-file#label_pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, this LGTM.
Fixes: #1935
If merged, pull requests can be backported automagically if labeled with
backport/<release-branch>
.