Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devx): allow automated backporting of PRs #1936

Merged
merged 1 commit into from
May 13, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented May 2, 2024

Fixes: #1935

If merged, pull requests can be backported automagically if labeled with backport/<release-branch>.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit bb6a8e3
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/6634005eb14cd60009683009
😎 Deploy Preview https://deploy-preview-1936.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiddeco hiddeco force-pushed the automated-backporting branch from 2f43805 to c85f2d7 Compare May 2, 2024 21:03
# xref: https://github.com/korthout/backport-action#inputs
with:
# Use token to allow workflows to be triggered for the created PR
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this GitHub secret is available to this repository, but I noticed it was used in some others within this GitHub organization.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the automated-backporting branch from c85f2d7 to bb6a8e3 Compare May 2, 2024 21:06
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.67%. Comparing base (e90b388) to head (bb6a8e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1936   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files         235      235           
  Lines       15825    15825           
=======================================
  Hits         7228     7228           
  Misses       8241     8241           
  Partials      356      356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Use token to allow workflows to be triggered for the created PR
github_token: ${{ secrets.GITHUB_TOKEN }}
# Match labels with pattern `backport/<target-branch>`
label_pattern: '^backport\/([^ ]+)$'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Where does $target_branch get set? I see a capture group in this regex, but I do not see where or how $target_branch takes on that value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The capture group is automatically taken as the target branch, see: https://github.com/korthout/backport-action?tab=readme-ov-file#label_pattern

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, this LGTM.

@hiddeco hiddeco added this pull request to the merge queue May 13, 2024
Merged via the queue into akuity:main with commit 5ffe26c May 13, 2024
16 checks passed
@hiddeco hiddeco deleted the automated-backporting branch May 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow automatic backporting of pull requests
3 participants