-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use akuitybot PAT for backport worfklow #2005
Conversation
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2005 +/- ##
=======================================
Coverage 46.23% 46.23%
=======================================
Files 235 235
Lines 16029 16029
=======================================
Hits 7411 7411
Misses 8256 8256
Partials 362 362 ☔ View full report in Codecov by Sentry. |
@@ -22,7 +22,7 @@ jobs: | |||
# xref: https://github.com/korthout/backport-action#inputs | |||
with: | |||
# Use token to allow workflows to be triggered for the created PR | |||
github_token: ${{ secrets.GITHUB_TOKEN }} | |||
github_token: ${{ secrets.AKUITYBOT_PAT }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would permissions.pull-requests: write
possibly work?
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... nevermind... I was looking at perms at the top of the file. I see this job already has the one I mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... this needs to be enabled at the org and repo level. Repo settings are already correct. Perhaps @kencochrane can check if Allow GitHub Actions to create and approve pull requests
is checked at the org level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kencochrane were the org settings already like that or did you check that box just now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't change any values; that is what it had.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kencochrane I have a feeling the repository needs to be added to the allow list of the organization global secret.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have an AKUITYBOT_PAT
org secret on the akuity
GitHub organization; we have one on our akuityio
organization. That is probably the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to ask @jessesuen if he can add it since I don't have the AKUITYBOT_PAT value to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am dumbfounded by why the pull-requests: write
permission isn't working, but am willing to accept this workaround in the interim.
This should ensure workflows are properly triggered in all scenarios. Follow up on #1936.