Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use akuitybot PAT for backport worfklow #2005

Merged
merged 1 commit into from
May 13, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented May 13, 2024

This should ensure workflows are properly triggered in all scenarios. Follow up on #1936.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Copy link

netlify bot commented May 13, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 8d4e741
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/664266506b91270008988072
😎 Deploy Preview https://deploy-preview-2005.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.23%. Comparing base (ecf3531) to head (8d4e741).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files         235      235           
  Lines       16029    16029           
=======================================
  Hits         7411     7411           
  Misses       8256     8256           
  Partials      362      362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -22,7 +22,7 @@ jobs:
# xref: https://github.com/korthout/backport-action#inputs
with:
# Use token to allow workflows to be triggered for the created PR
github_token: ${{ secrets.GITHUB_TOKEN }}
github_token: ${{ secrets.AKUITYBOT_PAT }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would permissions.pull-requests: write possibly work?

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

Copy link
Member

@krancour krancour May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... nevermind... I was looking at perms at the top of the file. I see this job already has the one I mentioned.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... this needs to be enabled at the org and repo level. Repo settings are already correct. Perhaps @kencochrane can check if Allow GitHub Actions to create and approve pull requests is checked at the org level.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kargo settings:
image

Org settings:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencochrane were the org settings already like that or did you check that box just now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change any values; that is what it had.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kencochrane I have a feeling the repository needs to be added to the allow list of the organization global secret.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have an AKUITYBOT_PAT org secret on the akuity GitHub organization; we have one on our akuityio organization. That is probably the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to ask @jessesuen if he can add it since I don't have the AKUITYBOT_PAT value to add it.

Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am dumbfounded by why the pull-requests: write permission isn't working, but am willing to accept this workaround in the interim.

@hiddeco hiddeco added this pull request to the merge queue May 13, 2024
Merged via the queue into akuity:main with commit 6674c67 May 13, 2024
20 of 23 checks passed
@hiddeco hiddeco deleted the fix-backport-workflow branch May 13, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants