refactor(promotion): remove priority queue #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
remove-priority-queue
branch
from
70b3652 to
468f9cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2779 +/- ##
==========================================
- Coverage 49.05% 48.90% -0.16%
==========================================
Files 272 270 -2
Lines 24196 23893 -303
==========================================
- Hits 11870 11684 -186
+ Misses 11690 11581 -109
+ Partials 636 628 -8 ☔ View full report in Codecov by Sentry. |
krancour
approved these changes
Oct 18, 2024
hiddeco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2762
As the Stage now decides which Promotion is the next candidate, a priority queue is no longer required. Instead, the Promotion reconciler watches Stages for a change that indicates what Promotion should be handled next and queues this object.