Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stage): wait for running verification to finish before next Promotion #2762

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Oct 17, 2024

Fixes: #2152
Fixes: #2128
Fixes: #2693

💡With the Stage mechanism determining what Promotion should be allowed to be processed next, we can get rid of the prioritized queue sometime in the future.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 0574419
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6711c985a1bb5d000891d545
😎 Deploy Preview https://deploy-preview-2762--docs-kargo-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco force-pushed the fix-verification-sync branch from fa376cd to 1e575de Compare October 17, 2024 14:40
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 37.37374% with 62 lines in your changes missing coverage. Please review.

Project coverage is 49.05%. Comparing base (43031a5) to head (0574419).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/promotions/watches.go 0.00% 36 Missing ⚠️
internal/controller/promotions/promotions.go 48.48% 15 Missing and 2 partials ⚠️
internal/controller/stages/stages.go 70.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
- Coverage   49.54%   49.05%   -0.49%     
==========================================
  Files         271      272       +1     
  Lines       19685    24196    +4511     
==========================================
+ Hits         9753    11870    +2117     
- Misses       9301    11690    +2389     
- Partials      631      636       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco marked this pull request as ready for review October 17, 2024 15:21
@hiddeco hiddeco requested a review from a team as a code owner October 17, 2024 15:21
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco and others added 2 commits October 17, 2024 21:32
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour
Copy link
Member

Test drove and this works quite well, except for one thing, which is that I find after a promo fails, I need to refresh the Stage to queue it for reconciliation and make it acknowledge the new highest priority promo as the current promo.

Something up with the stage reconciler's watch on promo status changes maybe?? A guess.

@hiddeco
Copy link
Contributor Author

hiddeco commented Oct 17, 2024

I have been unable to reproduce what you describe, but did find a UI bug which I took note of in #2773.

@hiddeco hiddeco enabled auto-merge October 17, 2024 21:45
@hiddeco hiddeco added this pull request to the merge queue Oct 18, 2024
Merged via the queue into akuity:main with commit 6a2d14b Oct 18, 2024
14 of 17 checks passed
@hiddeco hiddeco deleted the fix-verification-sync branch October 18, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment