-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stage): wait for running verification to finish before next Promotion #2762
Conversation
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
fa376cd
to
1e575de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
- Coverage 49.54% 49.05% -0.49%
==========================================
Files 271 272 +1
Lines 19685 24196 +4511
==========================================
+ Hits 9753 11870 +2117
- Misses 9301 11690 +2389
- Partials 631 636 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com>
Test drove and this works quite well, except for one thing, which is that I find after a promo fails, I need to refresh the Stage to queue it for reconciliation and make it acknowledge the new highest priority promo as the current promo. Something up with the stage reconciler's watch on promo status changes maybe?? A guess. |
I have been unable to reproduce what you describe, but did find a UI bug which I took note of in #2773. |
Fixes: #2152
Fixes: #2128
Fixes: #2693
💡With the Stage mechanism determining what Promotion should be allowed to be processed next, we can get rid of the prioritized queue sometime in the future.