Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(controller): replace http step timeoutSeconds with timeout #3066

Merged
merged 1 commit into from
Dec 5, 2024
Merged

refactor(controller): replace http step timeoutSeconds with timeout #3066

merged 1 commit into from
Dec 5, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented Dec 5, 2024

This is not a breaking chance because the http step has not been released yet.

@krancour
replace http step timeoutSeconds with timeout
7c09f3c 
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
@krancour krancour added this to the v1.1.0 milestone Dec 5, 2024
@krancour krancour self-assigned this Dec 5, 2024
@krancour krancour requested review from a team as code owners December 5, 2024 19:46
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 7c09f3c
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6752033189900c0008adc1b5
😎 Deploy Preview https://deploy-preview-3066.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (58588b8) to head (7c09f3c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/http_requester.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3066   +/-   ##
=======================================
  Coverage   51.22%   51.22%           
=======================================
  Files         283      283           
  Lines       25456    25462    +6     
=======================================
+ Hits        13039    13044    +5     
- Misses      11720    11722    +2     
+ Partials      697      696    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Dec 5, 2024
Merged via the queue into akuity:main with commit eb06e18 Dec 5, 2024
26 checks passed
@krancour krancour deleted the krancour/timeout-seconds branch December 5, 2024 20:42
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@krancour @github-actions
refactor(controller): replace http step timeoutSeconds with timeout (#…
c330c18 
…3066)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit eb06e18)
@akuitybot akuitybot mentioned this pull request Dec 5, 2024
Merged
@akuitybot
Copy link

Successfully created backport PR for release-1.1:

fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
@krancour @fykaa
refactor(controller): replace http step timeoutSeconds with timeout (a…
7f3e8a1 
…kuity#3066)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees

@krancour krancour

Labels
area/controller backport/release-1.1 kind/refactor priority/high
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@krancour @akuitybot @hiddeco