Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): refactor(controller): replace http step timeoutSeconds with timeout #3070

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

akuitybot
Copy link

Automated backport to release-1.1, triggered by a label in #3066.

…3066)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit eb06e18)
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.21%. Comparing base (c84e44a) to head (c330c18).
Report is 1 commits behind head on release-1.1.

Files with missing lines Patch % Lines
internal/directives/http_requester.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.1    #3070   +/-   ##
============================================
  Coverage        51.21%   51.21%           
============================================
  Files              283      283           
  Lines            25450    25456    +6     
============================================
+ Hits             13033    13038    +5     
- Misses           11720    11722    +2     
+ Partials           697      696    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour enabled auto-merge (squash) December 5, 2024 20:52
@krancour krancour added this to the v1.1.0 milestone Dec 5, 2024
@krancour krancour merged commit 069d141 into release-1.1 Dec 5, 2024
19 checks passed
@krancour krancour deleted the backport-3066-to-release-1.1 branch December 5, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants