-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make containerized make targets support alternative container runtimes #906
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
258d7e9
to
b345320
Compare
I'd prefer this just be an env var you can set, with docker as the default. This script will always prefer podman over docker if podman is found and I don't think it's reasonable to infer that everyone who has podman prefers it over docker. |
i can replace the order the docker will be the first and podman the second or make just as the env var with remarks your call |
98ddef2
to
125e26e
Compare
The env var... the thing is that I anticipate there will be plenty of people who prefer one or the other but happen to have both for... reasons. |
No prob, I will patch that later |
9304865
to
ad176d1
Compare
69ed17e
to
e3b240e
Compare
> you can use podman by creating an environment variable | ||
```bash | ||
export CONTAINER_RUNTIME=podman | ||
``` | ||
|
||
[How to config podman socket](https://docs.podman.ioen/latest/markdown/podman-system-service.1.html#examples) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to be podman-specific here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to be podman-specific here?
I realized my meaning might have been ambiguous.
The comment wasn't about the podman socket setup.
It was about the general idea of this PR adding prodman support.
I'm fine with the notion of supporting alternative container runtimes as long as they are "Docker compatible," but I'm less ok with presenting podman as a specially preferred/specially supported alternative container runtime... if that makes any sense.
I think the easiest thing to do here might be to just not mention this in the docs. The changes to the Makefile
are good and I think anyone who really cares about using an alternative container runtime will find the way of doing it easily enough.
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal <thason@redhat.com> Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
…th podman instructions Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Kent <kent.rancourt@gmail.com> Signed-off-by: Tal Hason <thason@redhat.com>
Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com> Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: dhanu <andreasdhanu@gmail.com> Co-authored-by: Kent Rancourt <kent.rancourt@gmail.com> Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Samuel Suter <samuel@suter.is> Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
Signed-off-by: Tal Hason <thason@redhat.com>
82f978f
to
948c8db
Compare
@tal-hason idk what happened with this PR, but it seems to include changes that are already in Sorry... really no idea how it ended up in this odd state. |
i can make a new branch from a fresh and just add the changes, maybe later on |
Opened #950 PR with a fresh branch |
as of #905
i have update the make file to work with an environment variable CONTAINER_RUNTIME, replaced it with the "docker" in the files
at the beginning of the make file I have added a bash script that checks if podman or docker exists and stores it in the CONTAINER_RUNTIME env. var